Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact(api): update common 1.2 & fix jersey client code problem #2365

Merged
merged 19 commits into from
Dec 7, 2023

Conversation

zhenyuT
Copy link
Contributor

@zhenyuT zhenyuT commented Nov 29, 2023

Purpose of the PR

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (e8fb269) 56.35% compared to head (92334af) 66.29%.

Files Patch % Lines
...ugegraph/api/gremlin/AbstractJerseyRestClient.java 84.00% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2365      +/-   ##
============================================
+ Coverage     56.35%   66.29%   +9.93%     
- Complexity      545      828     +283     
============================================
  Files           509      510       +1     
  Lines         42139    42187      +48     
  Branches       5836     5840       +4     
============================================
+ Hits          23749    27968    +4219     
+ Misses        15897    11451    -4446     
- Partials       2493     2768     +275     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imbajin imbajin changed the title update common version and fix jersey client code refact(api): update common 1.2 & fix jersey client code problem Dec 4, 2023
@imbajin imbajin added this to the 1.2.0 milestone Dec 4, 2023
@imbajin imbajin mentioned this pull request Dec 5, 2023
11 tasks
@simon824 simon824 merged commit 47aa8be into apache:master Dec 7, 2023
21 checks passed
VGalaxies pushed a commit to VGalaxies/incubator-hugegraph that referenced this pull request Jan 12, 2024
…he#2365)

* update common version and fix rest client problem

* use stage

* fix dependency issue

* test

* test

* test

* test

* fix

* chore:  improve the ci logic

* fix core-version

* Empty test

* fix code issue

* fix: 3rd party changes

* code optimize

* refactor the AbsJerseyRestClient

* fix code issue

---------

Co-authored-by: imbajin <jin@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants