-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support docker use the auth when starting #2403
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2403 +/- ##
============================================
- Coverage 65.59% 59.46% -6.13%
- Complexity 587 800 +213
============================================
Files 511 511
Lines 42590 42595 +5
Branches 5941 5942 +1
============================================
- Hits 27936 25331 -2605
- Misses 11840 14634 +2794
+ Partials 2814 2630 -184 ☔ View full report in Codecov by Sentry. |
hugegraph-server/hugegraph-dist/src/assembly/static/bin/util.sh
Outdated
Show resolved
Hide resolved
Co-authored-by: imbajin <jin@apache.org>
hugegraph-server/hugegraph-dist/src/assembly/static/bin/set-auth.sh
Outdated
Show resolved
Hide resolved
hugegraph-server/hugegraph-dist/src/assembly/static/bin/util.sh
Outdated
Show resolved
Hide resolved
hugegraph-server/hugegraph-dist/src/assembly/static/bin/util.sh
Outdated
Show resolved
Hide resolved
hugegraph-server/hugegraph-dist/src/assembly/static/bin/set-auth.sh
Outdated
Show resolved
Hide resolved
@@ -16,9 +16,20 @@ | |||
# under the License. | |||
# | |||
|
|||
curl --version >/dev/null 2>&1 || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove a redundant docker-entrypoint.sh, not move the file to download_keystore.sh
@@ -39,7 +39,7 @@ services: | |||
retries: 3 | |||
|
|||
cassandra: | |||
image: cassandra:4 | |||
image: cassandra:3.11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we setback to the version 3.x?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#2374
I remember we rollback cassandra to 3.11 and it is approved by one reviewer.
But i find the pr it suspend just now.
I will adjust the yaml with license together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#2374 I remember we rollback cassandra to 3.11 and it is approved by one reviewer. But i find the pr it suspend just now. I will adjust the yaml with license together.
the problem has been solved (temporarily?), so no need to rollback it for now~
hugegraph-server/hugegraph-dist/src/assembly/static/bin/wait-storage.sh
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have tested the new scripts for docker image?
Tested. |
@aroundabout Great work! I left some comments for you to check~ |
- allow user to set env for docker to set auth mode - download keystore when package - fix a curl error (also use curl first in `function` download) --------- Co-authored-by: imbajin <jin@apache.org>
- allow user to set env for docker to set auth mode - download keystore when package - fix a curl error (also use curl first in `function` download) --------- Co-authored-by: imbajin <jin@apache.org>
- allow user to set env for docker to set auth mode - download keystore when package - fix a curl error (also use curl first in `function` download) --------- Co-authored-by: imbajin <jin@apache.org>
1. sync with [2403](apache/incubator-hugegraph#2403) 2. change the order of the changelogs (there is a small problem in the origin order), and make the weight larger so that we can set the weight for version 1.5.0 to 10-1=9, where 10 is the weight for 1.2.0 3. Put the relevant parts of docker first --------- Co-authored-by: imbajin <jin@apache.org>
1. sync with [2403](apache/incubator-hugegraph#2403) 2. change the order of the changelogs (there is a small problem in the origin order), and make the weight larger so that we can set the weight for version 1.5.0 to 10-1=9, where 10 is the weight for 1.2.0 3. Put the relevant parts of docker first --------- Co-authored-by: imbajin <jin@apache.org> d2b63d9
Purpose of the PR
Todo
Main Changes
download
)Verifying these changes
use the yaml below
visit
http://localhost:8080/swagger-ui/index.html#/
set the user
admin
and password123456
and use theArthasAPI
and you can see
download
)copy the download function and run:
I cannot repeat error that we cannot curl from
localhost:8080
, insteat i change the line 108 instart-hugegraph.sh
and runbin/start-hugegraph.sh
and i get the result:
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODO
Doc - Done
Doc - No Need