-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refact(server): enlarge bytes write limit & remove param big
when encode/decode string id length
#2622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
This PR changes 10-29 lines, ignoring generated files.
label
Aug 6, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2622 +/- ##
============================================
- Coverage 48.70% 45.17% -3.54%
+ Complexity 708 583 -125
============================================
Files 729 718 -11
Lines 59508 58434 -1074
Branches 7659 7491 -168
============================================
- Hits 28984 26398 -2586
- Misses 27628 29318 +1690
+ Partials 2896 2718 -178 ☔ View full report in Codecov by Sentry. |
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
and removed
size:S
This PR changes 10-29 lines, ignoring generated files.
labels
Aug 6, 2024
imbajin
reviewed
Aug 6, 2024
...server/hugegraph-core/src/main/java/org/apache/hugegraph/backend/serializer/BytesBuffer.java
Outdated
Show resolved
Hide resolved
imbajin
changed the title
chore(server): enlarge bytes write limit & encode string id length with 2 bits by default
refact(server): enlarge bytes write limit & encode string id length with 2 bits
Aug 7, 2024
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
and removed
size:M
This PR changes 30-99 lines, ignoring generated files.
labels
Aug 7, 2024
VGalaxies
changed the title
refact(server): enlarge bytes write limit & encode string id length with 2 bits
refact(server): enlarge bytes write limit & remove param Aug 7, 2024
big
when encode/decode string id length
imbajin
reviewed
Aug 8, 2024
hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/structure/HugeEdge.java
Outdated
Show resolved
Hide resolved
imbajin
previously approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THX~
JackyYangPassion
approved these changes
Aug 10, 2024
imbajin
approved these changes
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title, change limit:
fix #1593 #2291