Fix bug in quering with joint labels #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #456 +/- ##
============================================
+ Coverage 68.96% 69.01% +0.04%
- Complexity 3273 3281 +8
============================================
Files 208 208
Lines 16146 16159 +13
Branches 2321 2325 +4
============================================
+ Hits 11135 11152 +17
+ Misses 3768 3762 -6
- Partials 1243 1245 +2
Continue to review full report at Codecov.
|
javeme
requested changes
Apr 15, 2019
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/query/ConditionQuery.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/query/ConditionQuery.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/query/ConditionQuery.java
Outdated
Show resolved
Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/core/VertexCoreTest.java
Show resolved
Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/core/VertexCoreTest.java
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/optimize/TraversalUtil.java
Outdated
Show resolved
Hide resolved
zhoney
requested changes
Apr 15, 2019
hugegraph-test/src/main/java/com/baidu/hugegraph/core/VertexCoreTest.java
Show resolved
Hide resolved
javeme
requested changes
Apr 16, 2019
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/query/ConditionQuery.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/query/ConditionQuery.java
Outdated
Show resolved
Hide resolved
zhoney
requested changes
Apr 16, 2019
| public boolean hasDuplicateKeys(Set<HugeKeys> keys) { | ||
| Map<HugeKeys, Integer> keyCounts = new HashMap<>(); | ||
| for (Condition condition : this.conditions()) { | ||
| if (!condition.isRelation()) { |
There was a problem hiding this comment.
All conditions should be relations. Check them.
Change-Id: I41d63884fed05c59d03daffa0d7b7b0851a869e1
Change-Id: Id47034ec856815e3835d325cc1f4dd0a02177b0f
Change-Id: Ia2a700a5f7adad2af62a7d77def3f23c6b87beed
Change-Id: I03392f3af3d6cb819d22fb7f86971834877db52f
Linary
force-pushed
the
flatten-joint-labels
branch
from
77829be to
16b4ea3
Compare
zhoney
requested changes
Apr 17, 2019
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/query/ConditionQuery.java
Outdated
Show resolved
Hide resolved
Change-Id: I21c8b767784fe68487b334ba4d9cb4ddcc53a306
Linary
force-pushed
the
flatten-joint-labels
branch
from
b4ff14e to
fe48ef4
Compare
javeme
approved these changes
Apr 17, 2019
zhoney
approved these changes
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I41d63884fed05c59d03daffa0d7b7b0851a869e1