Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: don't do remove-index if it's CREATING status #465

Merged
merged 1 commit into from
Apr 19, 2019

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Apr 18, 2019

about 10% performance improvement with tinkerpop tests.

also fix bug: delete-index-by-label deosn't work in InMemory backend.

Change-Id: Ie2cab7aef7e6e992d9dc3e3814eddf4adbc9f1bd

@codecov
Copy link

codecov bot commented Apr 18, 2019

Codecov Report

Merging #465 into master will increase coverage by 0.06%.
The diff coverage is 82.75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #465      +/-   ##
============================================
+ Coverage     68.92%   68.98%   +0.06%     
- Complexity     3278     3280       +2     
============================================
  Files           208      208              
  Lines         16170    16193      +23     
  Branches       2327     2334       +7     
============================================
+ Hits          11145    11171      +26     
+ Misses         3780     3778       -2     
+ Partials       1245     1244       -1
Impacted Files Coverage Δ Complexity Δ
...du/hugegraph/backend/tx/GraphIndexTransaction.java 80% <ø> (+0.15%) 146 <0> (+1) ⬆️
...u/hugegraph/backend/store/hbase/HbaseSessions.java 64.59% <ø> (ø) 22 <0> (ø) ⬇️
...u/hugegraph/backend/serializer/TextSerializer.java 80.91% <100%> (ø) 81 <0> (ø) ⬇️
...m/baidu/hugegraph/backend/tx/GraphTransaction.java 82.12% <100%> (ø) 208 <0> (ø) ⬇️
...idu/hugegraph/job/schema/RebuildIndexCallable.java 85.71% <75%> (+1.42%) 19 <0> (+1) ⬆️
...gegraph/backend/store/memory/InMemoryDBTables.java 78.42% <82.6%> (+1.47%) 0 <0> (ø) ⬇️
...ain/java/com/baidu/hugegraph/task/TaskManager.java 60.86% <0%> (-4.35%) 10% <0%> (-1%)
...e/src/main/java/com/baidu/hugegraph/HugeGraph.java 70.92% <0%> (+0.31%) 60% <0%> (ø) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2890c96...e6cd1f9. Read the comment docs.

@javeme javeme force-pushed the optimize-remove-index branch from 540149e to b869e41 Compare April 19, 2019 03:42
about 10% performance improvement with tinkerpop tests.

also fix bug: delete-index-by-label deosn't work in InMemory backend.

Change-Id: Ie2cab7aef7e6e992d9dc3e3814eddf4adbc9f1bd
@javeme javeme force-pushed the optimize-remove-index branch from b869e41 to e6cd1f9 Compare April 19, 2019 03:43
@zhoney zhoney merged commit 2418d51 into master Apr 19, 2019
@zhoney zhoney deleted the optimize-remove-index branch April 19, 2019 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants