Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update default config properties #575

Merged
merged 2 commits into from
Jun 24, 2019

Conversation

imbajin
Copy link
Member

@imbajin imbajin commented Jun 18, 2019

  1. update cache options
  2. add default config for hbase
  3. make mysql's SSL configuration effective

1. update cache options
2. add default config for hbase
3. make mysql's SSL configuration effective
@@ -95,7 +95,7 @@ public static synchronized MysqlOptions instance() {
"jdbc.ssl_mode",
"The SSL mode of connections with database.",
disallowEmpty(),
"disable"
"false"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also update SSL_MODE to JDBC_SSL_MODE

@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #575 into master will decrease coverage by 0.7%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #575      +/-   ##
============================================
- Coverage     70.38%   69.67%   -0.71%     
+ Complexity     3450     3406      -44     
============================================
  Files           216      216              
  Lines         16535    16537       +2     
  Branches       2355     2355              
============================================
- Hits          11638    11522     -116     
- Misses         3653     3774     +121     
+ Partials       1244     1241       -3
Impacted Files Coverage Δ Complexity Δ
...du/hugegraph/backend/store/mysql/MysqlOptions.java 95.65% <ø> (ø) 3 <0> (ø) ⬇️
...u/hugegraph/backend/store/mysql/MysqlSessions.java 69.61% <100%> (+0.33%) 20 <0> (ø) ⬇️
...gegraph/backend/store/rocksdb/RocksDBFeatures.java 11.76% <0%> (-70.59%) 2% <0%> (-12%)
.../hugegraph/backend/store/rocksdb/RocksDBTable.java 21.73% <0%> (-57.61%) 9% <0%> (-24%)
...om/baidu/hugegraph/backend/store/BackendEntry.java 23.33% <0%> (-26.67%) 1% <0%> (ø)
...hugegraph/backend/store/rocksdb/RocksDBTables.java 43.67% <0%> (-12.65%) 0% <0%> (ø)
...raph/backend/store/rocksdb/RocksDBStdSessions.java 65.01% <0%> (-4.65%) 22% <0%> (-2%)
.../hugegraph/backend/store/rocksdb/RocksDBStore.java 53.84% <0%> (-4.24%) 36% <0%> (-7%)
...e/src/main/java/com/baidu/hugegraph/HugeGraph.java 71.6% <0%> (-1.27%) 64% <0%> (ø)
...hugegraph/backend/serializer/BinarySerializer.java 79.26% <0%> (-0.84%) 102% <0%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9763c6...d6fa61f. Read the comment docs.

@javeme javeme merged commit 7e3795b into apache:master Jun 24, 2019
@imbajin imbajin deleted the update-default-config branch September 12, 2019 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants