-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KOGITO-9454] Documenting java flow library #585
Conversation
0116aa1
to
b578114
Compare
🎊 PR Preview b07a8ce has been successfully built and deployed. See the documentation preview: https://sonataflow-docs-preview-pr-585.surge.sh |
964cd70
to
8905e2b
Compare
serverlessworkflow/modules/ROOT/pages/getting-started/java-embedded-workflows.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/getting-started/java-embedded-workflows.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, well done @fjtirado !
serverlessworkflow/modules/ROOT/pages/getting-started/java-embedded-workflows.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/getting-started/java-embedded-workflows.adoc
Outdated
Show resolved
Hide resolved
@kaldesai can you ptal? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine as a first approach, but I'm wondering where to put this guide. @domhanak do you have a suggestion?
serverlessworkflow/modules/ROOT/pages/getting-started/java-embedded-workflows.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/getting-started/java-embedded-workflows.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/getting-started/java-embedded-workflows.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/getting-started/java-embedded-workflows.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/getting-started/java-embedded-workflows.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/getting-started/java-embedded-workflows.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/getting-started/java-embedded-workflows.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/getting-started/java-embedded-workflows.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fjtirado I have some minor suggestions. Otherwise, your content looks good to me. Thank you!
…edded-workflows.adoc Co-authored-by: Kalyani Desai <43639538+kaldesai@users.noreply.github.com>
…edded-workflows.adoc Co-authored-by: Kalyani Desai <43639538+kaldesai@users.noreply.github.com>
…edded-workflows.adoc Co-authored-by: Kalyani Desai <43639538+kaldesai@users.noreply.github.com>
…edded-workflows.adoc Co-authored-by: Kalyani Desai <43639538+kaldesai@users.noreply.github.com>
…edded-workflows.adoc Co-authored-by: Kalyani Desai <43639538+kaldesai@users.noreply.github.com>
…edded-workflows.adoc Co-authored-by: Kalyani Desai <43639538+kaldesai@users.noreply.github.com>
…edded-workflows.adoc Co-authored-by: Kalyani Desai <43639538+kaldesai@users.noreply.github.com>
…edded-workflows.adoc Co-authored-by: Kalyani Desai <43639538+kaldesai@users.noreply.github.com>
serverlessworkflow/modules/ROOT/pages/getting-started/java-embedded-workflows.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/getting-started/java-embedded-workflows.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/getting-started/java-embedded-workflows.adoc
Outdated
Show resolved
Hide resolved
serverlessworkflow/modules/ROOT/pages/getting-started/java-embedded-workflows.adoc
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few suggestions, let me know
…edded-workflows.adoc Co-authored-by: Dominik Hanák <domhanak@users.noreply.github.com>
…edded-workflows.adoc Co-authored-by: Dominik Hanák <domhanak@users.noreply.github.com>
Documents java flow library
Closes/Fixes/Resolves #ISSUE-NUMBER
Description:
https://issues.redhat.com/browse/KOGITO-9454
Please make sure that your PR meets the following requirements:
Issue-XYZ Subject
[0.9.x] Issue-XYZ Subject
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.x
to backport the original PR to the7.67.x
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.