Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KOGITO-2123] - Remove duplicate BATS test #169

Merged
merged 1 commit into from
Jun 3, 2020
Merged

[KOGITO-2123] - Remove duplicate BATS test #169

merged 1 commit into from
Jun 3, 2020

Conversation

spolti
Copy link
Member

@spolti spolti commented Jun 1, 2020 •
edited
Loading

see: https://issues.redhat.com/browse/KOGITO-2123

Signed-off-by: spolti fspolti@redhat.com

Many thanks for submitting your Pull Request ❤️!

Please make sure your PR meets the following requirements:

  • You have read the contributors guide
  • Pull Request title is properly formatted: [KOGITO-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Your feature/bug fix has a testcase that verifies it
  • You've tested the new feature/bug fix in an actual OpenShift cluster

@spolti spolti added needs review 🔍 Pull Request that needs reviewers ready 🚀 PR is ready to be merged labels Jun 1, 2020
@spolti spolti added this to the v0.11.0 milestone Jun 1, 2020
@spolti
Copy link
Member Author

spolti commented Jun 1, 2020

didn't find more duplicated tests.

@spolti spolti changed the title [KOGITO-2123] - This is a public project. Please make sure to set the… [KOGITO-2123] - Remove duplicate BATS test Jun 1, 2020
@radtriste radtriste removed the ready 🚀 PR is ready to be merged label Jun 2, 2020
@spolti spolti force-pushed the KOGITO-2123 branch 2 times, most recently from 583e80e to db2f589 Compare June 2, 2020 16:41
@spolti
[KOGITO-2123] - Remove duplicate BATS test
c110f58 
Signed-off-by: spolti <fspolti@redhat.com>
@vaibhavjainwiz vaibhavjainwiz self-requested a review June 2, 2020 19:05
vaibhavjainwiz
vaibhavjainwiz approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@vaibhavjainwiz vaibhavjainwiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@spolti spolti merged commit 04f9b9c into apache:master Jun 3, 2020
@spolti spolti deleted the KOGITO-2123 branch June 3, 2020 12:24
@kie-ci3 kie-ci3 mentioned this pull request Sep 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kaitou786 Kaitou786 Kaitou786 approved these changes

@radtriste radtriste radtriste approved these changes

@vaibhavjainwiz vaibhavjainwiz vaibhavjainwiz approved these changes

@sutaakar sutaakar sutaakar approved these changes

Assignees
No one assigned
Labels
needs review 🔍 Pull Request that needs reviewers
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.
5 participants
@spolti @sutaakar @vaibhavjainwiz @radtriste @Kaitou786