Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#1387: Adjust pipelines to use the gpg key provided by Apache to sign the artifacts #1222

Merged
merged 2 commits into from
Jul 16, 2024
Merged

kie-issues#1387: Adjust pipelines to use the gpg key provided by Apache to sign the artifacts #1222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c45de89
Adjust pipelines to use the gpg key provided by Apache to sign the ar…
rodrigonull Jul 15, 2024
b9d69e1
Fix import gpg key function
rodrigonull Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 11 additions & 16 deletions .ci/jenkins/Jenkinsfile.zip.sources
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,16 @@ pipeline {
archiveArtifacts artifacts: "**/${SOURCES_FILE_NAME}"
}
}
// stage('Sign and upload the sources.zip') {
// steps {
// script {
// // TODO: Uncomment (and adjust) when we have required credentials available
// release.gpgImportKeyFromFileWithPassword(getReleaseGpgSignKeyCredsId(), getReleaseGpgSignPassphraseCredsId())
// release.gpgSignFileDetachedSignatureWithPassword(SOURCES_FILE_NAME, SIGNATURE_FILE_NAME, getReleaseGpgSignPassphraseCredsId())
// release.svnUploadFileToRepository(getReleaseSvnRepository(), getReleaseSvnCredsId(), TARGET_VERSION, SOURCES_FILE_NAME, SIGNATURE_FILE_NAME)
// }
// archiveArtifacts artifacts: "**/${SIGNATURE_FILE_NAME}"
// }
// }
stage('Sign and upload the sources.zip') {
steps {
script {
release.gpgImportKeyFromStringWithoutPassword(getReleaseGpgSignKeyCredsId())
release.gpgSignFileDetachedSignatureWithoutPassword(SOURCES_FILE_NAME, SIGNATURE_FILE_NAME)
release.svnUploadFileToRepository(getReleaseSvnRepository(), getReleaseSvnCredsId(), TARGET_VERSION, SOURCES_FILE_NAME, SIGNATURE_FILE_NAME)
}
archiveArtifacts artifacts: "**/${SIGNATURE_FILE_NAME}"
}
}
}
}

Expand All @@ -42,14 +41,10 @@ String getReleaseGpgSignKeyCredsId() {
return env.RELEASE_GPG_SIGN_KEY_CREDS_ID
}

String getReleaseGpgSignPassphraseCredsId() {
return env.RELEASE_GPG_SIGN_PASSPHRASE_CREDS_ID
}

String getReleaseSvnRepository() {
return env.RELEASE_SVN_REPOSITORY
}

String getReleaseSvnCredsId() {
return env.RELEASE_SVN_CREDS_ID
}
}
4 changes: 2 additions & 2 deletions .ci/jenkins/config/branch.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ cloud:
release:
gpg:
sign:
key-credentials-id: 'asf-release-gpg-signing-key'
passphrase-credentials-id: 'asf-release-gpg-signing-key-passphrase'
key-credentials-id: 'GPG_KEY'
passphrase-credentials-id: ''
svn:
staging-repository: <TO-BE-DEFINED>
credentials-id: <TO-BE-DEFINED>
Expand Down
17 changes: 17 additions & 0 deletions jenkins-pipeline-shared-libraries/vars/release.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,29 @@ def gpgImportKeyFromFileWithPassword(String gpgKeyCredentialsId, String gpgKeyPa
}
}

def gpgImportKeyFromStringWithoutPassword(String gpgKeyCredentialsId) {
withCredentials([string(credentialsId: gpgKeyCredentialsId, variable: 'SIGNING_KEY')]) {
// copy the key to singkey.gpg file in *plain text* so we can import it
sh """
echo "$SIGNING_KEY" > $WORKSPACE/signkey.gpg
# Please do not remove list keys command. When gpg is run for the first time, it may initialize some internals.
gpg --list-keys
gpg --batch --pinentry-mode=loopback --import signkey.gpg
rm $WORKSPACE/signkey.gpg
"""
}
}

def gpgSignFileDetachedSignatureWithPassword(String file, String signatureTarget, String gpgKeyPasswordCredentialsId) {
withCredentials([string(credentialsId: gpgKeyPasswordCredentialsId, variable: 'SIGNING_KEY_PASSWORD')]) {
sh "gpg --batch --sign --pinentry-mode=loopback --passphrase \"${SIGNING_KEY_PASSWORD}\" --output ${signatureTarget} --detach-sig ${file}"
}
}

def gpgSignFileDetachedSignatureWithoutPassword(String file, String signatureTarget) {
sh "gpg --batch --sign --pinentry-mode=loopback --output ${signatureTarget} --detach-sig ${file}"
}

boolean gpgIsValidDetachedSignature(String file, String signature) {
return sh(returnStatus: true, script: "gpg --batch --verify ${signature} ${file}") == 0
}
Expand Down
Loading