Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#954: Extended Services Runner erases data on dates with Decision Update #2168

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

ljmotta
Copy link
Contributor

@ljmotta ljmotta commented Feb 20, 2024

Closes apache/incubator-kie-issues#954

Description

The DateTimeField component saves its value as a Date object and AJV handles the date-time type as a string. This discrepancy caused the Date value to be removed after a new edit. This PR skips the error keyword type for the date-time type when the data is a Date.

dmn-runner-954.mp4

Copy link
Contributor

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for a quick fix, one question from me @ljmotta

packages/dmn-runner/src/jsonSchema.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updates @ljmotta .

@tiagobento tiagobento merged commit f821ead into apache:main Feb 22, 2024
8 checks passed
paulovmr pushed a commit to kiegroup/kie-tools that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extended Services Runner erases data on dates with Decision Update
3 participants