Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Remove workflow plugin dependency on knative/client int… #2293

Merged
merged 1 commit into from
May 17, 2024

Conversation

treblereel
Copy link
Contributor

@treblereel treblereel commented May 6, 2024

…erface

issue: apache/incubator-kie-issues#1228

(cherry picked from commit dc7a3ec)

@wmedvede wmedvede self-requested a review May 6, 2024 10:18
@domhanak domhanak changed the title SRVLOGIC-289: Remove workflow plugin dependency on knative/client int… NO-ISSUE: Remove workflow plugin dependency on knative/client int… May 6, 2024
@domhanak domhanak requested a review from tomasdavidorg May 7, 2024 07:17
@domhanak
Copy link
Contributor

domhanak commented May 7, 2024

@tomasdavidorg fyi, want to check?

@tiagobento tiagobento requested a review from caponetto May 8, 2024 20:35
@caponetto
Copy link
Contributor

@treblereel The CI on Windows has failed. Could you please check?

@treblereel treblereel force-pushed the remove-knative-dep branch 3 times, most recently from 6125582 to fa3eeaf Compare May 14, 2024 04:11
@treblereel
Copy link
Contributor Author

hmm,

packages/kogito-serverless-operator build:dev: ./hack/goimports.sh
packages/kogito-serverless-operator build:dev: Windows Subsystem for Linux has no installed distributions.
packages/kogito-serverless-operator build:dev: Distributions can be installed by visiting the Microsoft Store:
packages/kogito-serverless-operator build:dev: https://aka.ms/wslstore

not sure it's related to this pr, but lets take a look

@treblereel treblereel force-pushed the remove-knative-dep branch from fa3eeaf to 82023ed Compare May 16, 2024 18:03
@tiagobento
Copy link
Contributor

@treblereel I saw you made #2339, which is a great test. I went looking into the changes of this PR and indeed there was no indication that the changes were related with the failure.

Because you changed kn-plugin-workflow, all dependencies are built with build:dev (ignoring tests, linters etc). However, the kogito-serverless-operator package is configured with a command for Windows that doesn't seem to work. If you look at the build:prod command, the build is skipped.

Please change build:dev:win32 to "build:dev:win32": "echo 'Build not supported on Windows'",, so the kogito-serverless-operator package is also not built on Windows in development mode.

Sorry for the inconvenience! And great idea of sending this separate PR.

@treblereel
Copy link
Contributor Author

It looks like CI is broke, #2339

@treblereel
Copy link
Contributor Author

@tiagobento yeap, let me do a separate PR for this.

@treblereel treblereel force-pushed the remove-knative-dep branch from 82023ed to 6c8c6d8 Compare May 16, 2024 22:41
@tiagobento tiagobento merged commit 951478c into apache:main May 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants