kie-issue#1149: DMN Editor produces invalid typeRef attributes #2316
Conversation
danielzhe
added
pr: waiting-for-review
There was a problem hiding this comment.
@danielzhe Thanks for this change! I've added some comments inline
| allTopLevelDataTypesByFeelName: DataTypeIndex; | ||
| getInputs?: () => { name: string; typeRef: string | undefined }[] | undefined; | ||
| getDefaultColumnWidth?: (args: { name: string; typeRef: string | undefined }) => number | undefined; | ||
| widthsById: Map<string, number[]>; | ||
| }): BoxedExpression { | ||
| const dataType = allTopLevelDataTypesByFeelName.get(typeRef); | ||
| const dataType = allTopLevelDataTypesByFeelName.get(typeRef ?? "<Undefined>"); |
There was a problem hiding this comment.
"<Undefined>" is value used in a few places. Maybe extract to a variable? WDYT?
There was a problem hiding this comment.
You're right. I'm going to use the DmnBuiltInDataType.Undefined for this.
| @@ -98,7 +98,7 @@ const BoxedExpressionEditorWrapper: React.FunctionComponent<BoxedExpressionEdito | |||
| const beeGwtService: BeeGwtService = { | |||
| getDefaultExpressionDefinition(logicType, dataType, isRoot) { | |||
| const defaultExpression = gwtExpressionToDmnExpression( | |||
| window.beeApiWrapper?.getDefaultExpressionDefinition(gwtLogicType(logicType), dataType) | |||
| window.beeApiWrapper?.getDefaultExpressionDefinition(gwtLogicType(logicType), dataType ?? "<Undefined>") | |||
There was a problem hiding this comment.
The dataType parameter of getDefaultExpressionDefinition accepts an undefined value, why fallback to "<Undefined>"? Maybe should we fallback inside the method?
There was a problem hiding this comment.
Because this is to the GWT layer and since it will be removed in the future I think we should avoid spending time on it.
There was a problem hiding this comment.
This is not for display only, though, right? I mean, this is getting into the XML.
There was a problem hiding this comment.
As we talked in pvt, I changed it to the proposed change by @ljmotta :)
danielzhe
force-pushed
the
invalid-typeref
branch
from
e54aca6 to
be097a1
Compare
danielzhe
force-pushed
the
invalid-typeref
branch
from
be097a1 to
ed612b6
Compare
|
Changes applied! Ready for your review @ljmotta @tiagobento |
Closes: apache/incubator-kie-issues#1149
Some places related to the user interface are using "".
The places where the data is marshaled are using
undefined.The "" value is still present in
DmnBuiltInDataTypebecause it is still a "valid value".