Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-ISSUE: DMN Editor: fix external node underline (input data) #2360

Merged
merged 1 commit into from
May 23, 2024
Merged

NO-ISSUE: DMN Editor: fix external node underline (input data) #2360

merged 1 commit into from
May 23, 2024

Conversation

jomarko
Copy link
Contributor

@jomarko jomarko commented May 23, 2024

Before

External Input Data node isn't with the underlined name. The bug is present both for standard and alternative Input Data shape.

After

Screenshot 2024-05-23 125818
Screenshot 2024-05-23 125810

Josephblt
Josephblt approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@Josephblt Josephblt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working nicely.

@tiagobento tiagobento merged commit ca26ea2 into apache:main May 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josephblt Josephblt Josephblt approved these changes

@ljmotta ljmotta ljmotta approved these changes

@ederign ederign Awaiting requested review from ederign

@tiagobento tiagobento Awaiting requested review from tiagobento tiagobento is a code owner

@paulovmr paulovmr Awaiting requested review from paulovmr

Assignees
No one assigned
Labels
area:dmn
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jomarko @ljmotta @Josephblt @tiagobento