NO-ISSUE: Removing an Included Model should remove all references of it on the current model #2365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagoelg
approved these changes
May 24, 2024
Josephblt
approved these changes
May 24, 2024
jomarko
approved these changes
May 27, 2024
|
@gitgabrio @yesamer I've added messages for removing included DMNs and PMMLs.
|
yesamer
approved these changes
May 27, 2024
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new maps on the diagram data. The
externalNodesByNamespacecollects a list of external nodes that are present on the DRD, and theexternalEdgesByNamespacehas a list of edges that reference external nodes. ThedeleteImportnow iterates over the nodes and edges lists erasing all references.