[kie-tools#2571] [sonataflow-management-console] Convert Containerfiles to Cekit #2573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Image Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
There was a problem hiding this comment.
@ricardozanini Thank you so much for this PR.
I left some suggestions but I'm not totally sure about all of them.
I think we also need to rename KOGITO_MANAGEMENT_CONSOLE_PORT to SONATAFLOW_MANAGEMENT_CONSOLE_PORT in the Containerfile.
Of course, if this renaming makes sense for you as well.
...-management-console-image/resources/modules/sonataflow/management-console/configure-httpd.sh
Outdated
Show resolved
Hide resolved
...ow-management-console-image/resources/incubator-kie-sonataflow-management-console-image.yaml
Outdated
Show resolved
Hide resolved
...ow-management-console-image/resources/incubator-kie-sonataflow-management-console-image.yaml
Outdated
Show resolved
Hide resolved
...ataflow-management-console-image/resources/modules/sonataflow/management-console/module.yaml
Outdated
Show resolved
Hide resolved
|
@fantonangeli, thanks for the insights! |
Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
ricardozanini
changed the title
fantonangeli
approved these changes
Sep 12, 2024
|
@fantonangeli where u able to build and run the image locally? |
|
@ricardozanini Yes I tested successfully the image. I used the commands:
|
Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
ricardozanini
changed the title
Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
fantonangeli
approved these changes
Sep 12, 2024
tiagobento
changed the title
tiagobento
approved these changes
Sep 12, 2024
rgdoliveira
pushed a commit
to rgdoliveira/kie-tools
that referenced
this pull request
Sep 12, 2024
…es to Cekit (apache#2573) Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
rgdoliveira
added a commit
to kiegroup/kie-tools
that referenced
this pull request
Sep 12, 2024
…es to Cekit (apache#2573) (#43) Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com> Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2571
In this PR:
sonata flow-image-commonkogito-system-userwhen a base image already has the 1001 user id.Containerfilein favor of Cekit to support reproducible builds and BDD tests in the futureFollow-up issues: