[kie-issues#1755] - Display the correct git URL when creating a snippet, gist, or repo in the online editor #2863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Send the correct URL to the alert * Call the correct alert * Use the provided URL if available The code has been using `successfullyUpdatedGistOrSnippetAlert` instead of `successfullyCreatedGistOrSnippetAlert`. The alert was also not setup to properly make use of the provided URL when the alert was shown. Signed-off-by: Jason Porter <lightguard.jp@gmail.com>
jomarko
reviewed
Jan 17, 2025
There was a problem hiding this comment.
Thank you for the PR. I can confirm that creating of:
- github gist
- github repository
- bitbucket snippet
- bitbucket repository
does not include .git substring in the alert message shown after the operation is done.
However, the 'update' and 'push' operation for mentioned 4 cases still include .git substring. Should we handle also 'update' and 'push' operations?
thiagoelg
reviewed
Jan 17, 2025
| @@ -225,12 +225,12 @@ export function useGitIntegrationAlerts(workspace: ActiveWorkspace) { | |||
|
|
|||
| const successfullyCreatedGistOrSnippetAlert = useGlobalAlert( | |||
| useCallback( | |||
| ({ close }) => { | |||
| ({ close }, staticArgs?: { url: string }) => { | |||
There was a problem hiding this comment.
Could you add this to all gist related alerts here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: apache/incubator-kie-issues#1755
The code has been using
successfullyUpdatedGistOrSnippetAlertinstead ofsuccessfullyCreatedGistOrSnippetAlert. The alert was also not setup to properly make use of the provided URL when the alert was shown.