-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LIVY-995][REPL] JsonParseException is thrown when closing Livy session when using python profile #439
Conversation
…on when using python profile
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #439 +/- ##
=============================================
- Coverage 65.45% 28.56% -36.89%
+ Complexity 954 380 -574
=============================================
Files 103 103
Lines 6084 6091 +7
Branches 922 923 +1
=============================================
- Hits 3982 1740 -2242
- Misses 1546 3994 +2448
+ Partials 556 357 -199 ☔ View full report in Codecov by Sentry. |
hi @jerryshao I noticed you contributed to Livy's REPL module. Can you help review this PR? |
@jianzhenwu - can you add a unit test to show that the issue is resolved and ensure that it doesn't regress in the future? |
@lmccay thank you for your reply. I added unit tests to ensure no impact on original functionality and to verify expected functionality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
+1
@jianzhenwu - thanks for your contribution! I have merged this and it will be available in the next release. |
thank you |
…on when using python profile (apache#439) * [LIVY-995][REPL] JsonParseException is thrown when closing Livy session when using python profile
What changes were proposed in this pull request?
When Livy closes PythonInterpreter, the output may not be in JSON format, so there is no need to deserialize json.
https://issues.apache.org/jira/browse/LIVY-995
How was this patch tested?
manual tests
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review https://livy.incubator.apache.org/community/ before opening a pull request.