Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIVY-995][REPL] JsonParseException is thrown when closing Livy session when using python profile #439

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

jianzhenwu
Copy link
Contributor

What changes were proposed in this pull request?

When Livy closes PythonInterpreter, the output may not be in JSON format, so there is no need to deserialize json.
https://issues.apache.org/jira/browse/LIVY-995

How was this patch tested?

manual tests
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Please review https://livy.incubator.apache.org/community/ before opening a pull request.

@jianzhenwu jianzhenwu requested a review from jerryshao January 18, 2024 10:07
@jianzhenwu jianzhenwu self-assigned this Jan 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (86fc823) 65.45% compared to head (4336eab) 28.56%.

Files Patch % Lines
...scala/org/apache/livy/repl/PythonInterpreter.scala 0.00% 9 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master     #439       +/-   ##
=============================================
- Coverage     65.45%   28.56%   -36.89%     
+ Complexity      954      380      -574     
=============================================
  Files           103      103               
  Lines          6084     6091        +7     
  Branches        922      923        +1     
=============================================
- Hits           3982     1740     -2242     
- Misses         1546     3994     +2448     
+ Partials        556      357      -199     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jianzhenwu
Copy link
Contributor Author

hi @jerryshao I noticed you contributed to Livy's REPL module. Can you help review this PR?

@lmccay
Copy link
Contributor

lmccay commented Jan 19, 2024

@jianzhenwu - can you add a unit test to show that the issue is resolved and ensure that it doesn't regress in the future?
It would also be good to point to coverage or add new tests to ensure that previous functional expectations remain intact.

@jianzhenwu
Copy link
Contributor Author

@lmccay thank you for your reply. I added unit tests to ensure no impact on original functionality and to verify expected functionality.

@jianzhenwu jianzhenwu requested a review from lmccay January 24, 2024 06:24
Copy link
Contributor

@lmccay lmccay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
+1

@lmccay lmccay merged commit 96b1eb6 into apache:master Jan 25, 2024
3 checks passed
@lmccay
Copy link
Contributor

lmccay commented Jan 25, 2024

@jianzhenwu - thanks for your contribution! I have merged this and it will be available in the next release.

@jianzhenwu
Copy link
Contributor Author

thank you

jimenefe pushed a commit to onedot-data/incubator-livy that referenced this pull request Oct 15, 2024
…on when using python profile (apache#439)

* [LIVY-995][REPL] JsonParseException is thrown when closing Livy session when using python profile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants