This repository has been archived by the owner on Mar 25, 2024. It is now read-only.
refactor: allow for C-style convention when mixed with C++ source files #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please solve the conflicts. Provide a design kit in notion.so and tests in c++, that allows us to understand better the problem. Also you're moving out a lot of code around..can you provide the result of unit tests? |
|
@kittywhiskers can we have a call on this? I am interested to have a C++ wrapper but i don't know how we can move on this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There doesn't seem to be mentions of an official Milagro C++ wrapper and following in line with #24, work on a potential C++ implementation behind a C API will require C++ and C code to co-exist. Additionally, the prefix of
.c.inproves to be misleading as it prevents IDEs (like Visual Studio Code) from recognising C source files. This PR attempts to address portions of these issues.