Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEMO-327] Fix skew handling for multi shuffle edge receiver #189

Merged
merged 3 commits into from
Jan 22, 2019

Conversation

sanha
Copy link
Contributor

@sanha sanha commented Jan 22, 2019

JIRA: NEMO-327: Fix skew handling for multi shuffle edge receive

Major changes:

  • For the case that a vertex receives multiple shuffle edges, makes DataSkewPolicy collect metric data for the shuffle edges in a single metric aggregation vertex and optimize the edges at once.

Minor changes to note:

  • Makes runtime pass receive multiple target edges.

Tests for the changes:

  • Adds an integration test with the data skew policy for NetworkTraceAnalysis that has a join.

Other comments:

  • N/A.

Closes #189

@sanha sanha added the bug Something isn't working label Jan 22, 2019
@sanha sanha self-assigned this Jan 22, 2019
Copy link
Contributor

@johnyangk johnyangk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sanha 👍

@johnyangk johnyangk merged commit df44608 into apache:master Jan 22, 2019
@sanha sanha deleted the 327-MultiEdgeSkew branch January 23, 2019 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants