-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Work stealing in Nemo (alternative implementation) #321
Open
hwarim-hyun
wants to merge
28
commits into
apache:master
Choose a base branch
from
snuspl:follow_hurricane
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-nemo into follow_hurricane
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: NEMO-466 Dynamic Work Stealing on Nemo for handling skews
Major changes:
WorkStealingStatePass
andWorkStealingSubSplitPass
to enable annotations related to work stealing.WorkStealingStatePass
annotates three phases of work stealing process:DEFAULT
,SPLIT
, andMERGE
. These are tagged to the vertex based on the name assigned to beam transform by the user.SPLIT
phase and merged inMERGE
phase.WorkStealingSubSplitPass
annotates the number to split the tasks inSPLIT
phase.WorkStealingPolicy
, which executesWorkStealingPass
andWorkStealingSubSplitPass
additionally toDefaultCompositePass
.task id
andblock id
to differentiate between work stealing tasks and default tasks.task id
[stage id] - [task index] - [task attempt]
[stage id] - [task index] - [* or sub index for work stealing tasks] - [task attempt]
block id
[runtime edge id] - [producer task index] - [producer task attempt]
[runtime edge id] - [producer task index] - [producer task sub index] - [producer task attempt]
for blocks generated by work stealing tasks.Minor changes to note:
PipelineTranslator
to read the user tags given to the transform.PlanStateManager
andBlockInputReader
to manage work stealing tasks and non-split tasks together.Tests for the changes:
WorkStealingPolicy
. Note that in order to execute WorkStealing policy, the application pipeline should provide appropriate splitting and merging strategy.WorkStealingCompositePass
which encapsulatesWorkStealingStatePass
andWorkStealingSubSplitPass
ParentTaskDataFetcherTest
andTaskExecutorTest
, reflecting the changes inBlockInputReader
Other comments:
Closes #321