feat(log): Redacted user key-values printed in logs #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
reviewed
Sep 8, 2023
Samunroyu
force-pushed
the
dev/yjw/encrypt_log
branch
4 times, most recently
from
cf7d0eb to
31225b6
Compare
Samunroyu
force-pushed
the
dev/yjw/encrypt_log
branch
from
31225b6 to
076fb6e
Compare
acelyc111
reviewed
Oct 13, 2023
acelyc111
reviewed
Oct 16, 2023
acelyc111
previously approved these changes
Oct 17, 2023
|
@Samunroyu Could you please fix the IWYU issue, and add some unit tests for the 2 newly added functions? |
Samunroyu
force-pushed
the
dev/yjw/encrypt_log
branch
from
4481ebf to
4871d55
Compare
acelyc111
previously approved these changes
Oct 18, 2023
acelyc111
changed the title
acelyc111
changed the title
acelyc111
previously approved these changes
Oct 18, 2023
acelyc111
approved these changes
Oct 18, 2023
GehaFearless
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1575
User key-values will be redacted if encryption enabled.