feat(backup): 2. update and refactor meta backup engine class #2142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pr removes some previous backup implementation, because the enhancement code is strongly different with the current one. Besides, this pr also disable related unit tests and function tests.
acelyc111
reviewed
Nov 13, 2024
| 5:i64 start_time_ms; | ||
| 6:i64 end_time_ms; | ||
| 7:bool is_backup_failed; | ||
| 5:string backup_path; |
There was a problem hiding this comment.
While you change the field sequence, it would cause compatiable issues. How do you resolve it?
It's just the backup policy is incompatiable, however, the backup data is compatiable, that is to say, the backup data of the old implementation can be read normally by the new implemantation, right?
| _is_periodic_backup ? "periodic" : "onetime", | ||
| _cur_backup.backup_id, | ||
| _cur_backup.backup_provider_type, | ||
| _cur_backup.backup_path); |
There was a problem hiding this comment.
What about mention the URI of the backup destination?
| LOG_INFO("backup path is set to {}.", path); | ||
| _backup_path = path; | ||
| // TODO(heyuchen): TBD | ||
| // guoningshen: write app info on block service |
There was a problem hiding this comment.
Suggested change
| // guoningshen: write app info on block service | |
| // TODO(guoningshen): write app info on block service |
Comment on lines
+84
to
+85
| zauto_read_lock l(_lock); | ||
| backup_item item = _cur_backup; |
There was a problem hiding this comment.
Suggested change
| zauto_read_lock l(_lock); | |
| backup_item item = _cur_backup; | |
| { | |
| zauto_read_lock l(_lock); | |
| backup_item item = _cur_backup; | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#1945
As the issue shows, meta_backup_engine will intertact with replica server and contorl backup lifecycle and status switch. This pr is the first part about it, including:
1.update init_backup and start functions
2.update backup_status and backup_item structures
3.update varieties of meta_backup_engine.h
4.rename backup_engine into meta_backup_engine
5.refactor meta_backup_engine.h including public/private, function definition order etc.