This repository was archived by the owner on Feb 16, 2024. It is now read-only.
[S2GRAPH-107] Improve code readability by using code formatter and code style inspector like Scalafmt and Scalastyle #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alastyle settings
HyunsungJo
reviewed
Dec 8, 2016
| // val newConf = new util.HashMap[String, Object]() | ||
| // newConf.put("hbase.zookeeper.quorum", zkQuorum) | ||
| // newConf.put("db.default.url", database) | ||
| // newConf.put("kafka.metadata.broker.list", kafkaBrokers) |
Contributor
Author
There was a problem hiding this comment.
@HyunsungJo Yes, we can remove comments which have no useful information.
Contributor
|
@ijsong, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.apache.org/jira/browse/S2GRAPH-107
This PR has really big changes, but those are mostly related to code styles. In this PR, I changed level of some rules in scalastyle from warning to error. Many projects raise error rather than warning when scalastyle checker fails. In near future, we are able to change warning rule to raise error by do refactoring codebase. (I will create another issue to do refactoring our codebase according to some published scala best practice and design pattern.)
Tools related to code style which we use: