Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reactor: select for update executor #478

Merged
merged 4 commits into from
Feb 18, 2023

Conversation

Charlie17Li
Copy link
Contributor

@Charlie17Li Charlie17Li commented Feb 11, 2023

Signed-off-by: charlie qianglin98@qq.com

What this PR does:

  1. reactor the "select for update executor"
  2. fix the unit test for "select for update executor" failed

Which issue(s) this PR fixes:

Fixes #442

ref pr #465

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: charlie <qianglin98@qq.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2023

Codecov Report

Merging #478 (af122b7) into master (437f712) will decrease coverage by 0.08%.
The diff coverage is 29.46%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #478      +/-   ##
==========================================
- Coverage   39.05%   38.98%   -0.08%     
==========================================
  Files         144      146       +2     
  Lines        9120     9342     +222     
==========================================
+ Hits         3562     3642      +80     
- Misses       5264     5403     +139     
- Partials      294      297       +3     
Impacted Files Coverage Δ
pkg/client/client.go 0.00% <0.00%> (ø)
pkg/datasource/sql/exec/at/at_executor.go 0.00% <0.00%> (ø)
pkg/datasource/sql/exec/at/config.go 0.00% <0.00%> (ø)
pkg/datasource/sql/exec/at/delete_executor.go 22.77% <0.00%> (-0.70%) ⬇️
.../datasource/sql/exec/select_for_update_executor.go 0.00% <0.00%> (ø)
pkg/datasource/sql/types/executor.go 0.00% <0.00%> (ø)
.../sql/undo/builder/mysql_update_undo_log_builder.go 0.00% <0.00%> (ø)
...tasource/sql/exec/at/select_for_update_executor.go 29.95% <29.95%> (ø)
pkg/datasource/sql/exec/at/update_executor.go 25.00% <33.33%> (ø)
pkg/datasource/sql/exec/at/insert_executor.go 41.40% <57.14%> (+0.03%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: charlie <qianglin98@qq.com>
Signed-off-by: charlie <qianglin98@qq.com>
pkg/client/config.go Outdated Show resolved Hide resolved
Signed-off-by: charlie <qianglin98@qq.com>
@luky116 luky116 merged commit 291f13d into apache:master Feb 18, 2023
georgehao pushed a commit to georgehao/seata-go that referenced this pull request May 7, 2023
* reactor: select for update executor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate and test select for update sql
4 participants