bugfix: After 1.6.0, auto-increment of pgsql/oracle pk columns are no longer supported #5284
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
fix:1.6.0~1.6.1,AT模式,当insert语句不包含主键列时,无法获取到pgsql/oracle的自增主键值。
Ⅱ. Does this pull request fix one issue?
fixes #5264
Ⅲ. Why don't you add test cases (unit test/integration test)?
添加下面几个单测
io.seata.rm.datasource.exec.PostgresqlInsertExecutorTest#testGetPkValues_SinglePk
io.seata.rm.datasource.exec.PostgresqlInsertExecutorTest#testGetPkValues_MultiPk
io.seata.rm.datasource.exec.PostgresqlInsertExecutorTest#testContainsAnyPK
io.seata.rm.datasource.exec.OracleInsertExecutorTest#testGetPkValues_SinglePk
io.seata.rm.datasource.exec.OracleInsertExecutorTest#testGetPkValues_MultiPk
Ⅳ. Describe how to verify it
集成测试验证了下面几种情况
Ⅴ. Special notes for reviews