-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: RM TM startup connect server fail fast #6004
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6004 +/- ##
============================================
- Coverage 48.98% 48.87% -0.12%
+ Complexity 4782 4765 -17
============================================
Files 913 913
Lines 31697 31750 +53
Branches 3823 3835 +12
============================================
- Hits 15528 15518 -10
- Misses 14632 14689 +57
- Partials 1537 1543 +6
|
core/src/main/java/io/seata/core/rpc/netty/NettyClientChannelManager.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/seata/core/rpc/netty/AbstractNettyRemotingClient.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
core/src/main/java/io/seata/core/rpc/netty/NettyClientChannelManager.java
Outdated
Show resolved
Hide resolved
|
The server online/offline notifications in the registry center are based on a subscription mechanism. The "10s" mentioned here refers to the interval for checking the availability of servers. The registry center list displays the nodes that are deemed normal, but it doesn't guarantee that the clients can necessarily connect to them. |
core/src/main/java/io/seata/core/rpc/netty/NettyClientChannelManager.java
Outdated
Show resolved
Hide resolved
Yes, I know the current situation. What I mean is that the list after check can also be referenced in the process of subscription monitoring to determine whether the node can be deleted at the first time when it goes offline, and 10s check is still in place. 是的,我知道现在的情况,我的意思是check 后的列表一样可以引用到订阅监听的过程中去,用来判断当节点下线时,能够第一时间删除掉, 10s check还在. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6004 +/- ##
============================================
+ Coverage 49.75% 49.96% +0.21%
- Complexity 4885 4932 +47
============================================
Files 915 915
Lines 31885 31927 +42
Branches 3853 3855 +2
============================================
+ Hits 15863 15952 +89
+ Misses 14470 14411 -59
- Partials 1552 1564 +12
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
fixes: #5484
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews