Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize:remove Seata-Docker link #6218

Merged
merged 3 commits into from
Dec 26, 2023

Conversation

xingfudeshi
Copy link
Member

@xingfudeshi xingfudeshi commented Dec 26, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Remove Seata-Docker link

Ⅱ. Does this pull request fix one issue?

fixes #6217

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

funky-eyes
funky-eyes previously approved these changes Dec 26, 2023
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f3b27de) 49.04% compared to head (606c925) 48.97%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6218      +/-   ##
============================================
- Coverage     49.04%   48.97%   -0.07%     
+ Complexity     4786     4779       -7     
============================================
  Files           915      915              
  Lines         31896    31896              
  Branches       3855     3855              
============================================
- Hits          15644    15622      -22     
- Misses        14697    14715      +18     
- Partials       1555     1559       +4     

see 5 files with indirect coverage changes

@funky-eyes funky-eyes added this to the 2.1.0 milestone Dec 26, 2023
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi merged commit d2dbbff into apache:2.x Dec 26, 2023
6 checks passed
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Seata-Docker link
4 participants