-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: get real-time configuration according to Environment under file #6245
Conversation
…oon as possible when applicationContext closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6245 +/- ##
============================================
+ Coverage 49.90% 49.93% +0.02%
+ Complexity 4935 4928 -7
============================================
Files 917 915 -2
Lines 31995 31928 -67
Branches 3862 3855 -7
============================================
- Hits 15968 15944 -24
+ Misses 14469 14415 -54
- Partials 1558 1569 +11
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…oon as possible when applicationContext closed
Ⅰ. Describe what this PR did
#6223
Ⅱ. Does this pull request fix one issue?
fixes #6223
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews