Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: get real-time configuration according to Environment under file #6245

Merged
merged 4 commits into from
Jan 8, 2024

Conversation

laywin
Copy link
Contributor

@laywin laywin commented Jan 7, 2024

…oon as possible when applicationContext closed

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

#6223

Ⅱ. Does this pull request fix one issue?

fixes #6223

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1679849) 49.90% compared to head (4f9cbf5) 49.93%.
Report is 1 commits behind head on 2.x.

❗ Current head 4f9cbf5 differs from pull request most recent head 564fb26. Consider uploading reports for the commit 564fb26 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6245      +/-   ##
============================================
+ Coverage     49.90%   49.93%   +0.02%     
+ Complexity     4935     4928       -7     
============================================
  Files           917      915       -2     
  Lines         31995    31928      -67     
  Branches       3862     3855       -7     
============================================
- Hits          15968    15944      -24     
+ Misses        14469    14415      -54     
- Partials       1558     1569      +11     
Files Coverage Δ
...ure/provider/SpringApplicationContextProvider.java 100.00% <100.00%> (ø)

... and 26 files with indirect coverage changes

@funky-eyes funky-eyes changed the title optimize:take config into effective when spring config changed optimize: take config into effective when spring config changed Jan 8, 2024
funky-eyes
funky-eyes previously approved these changes Jan 8, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.1.0 milestone Jan 8, 2024
@funky-eyes funky-eyes changed the title optimize: take config into effective when spring config changed optimize: get real-time configuration according to Environment under file Jan 8, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 01e6f0c into apache:2.x Jan 8, 2024
5 checks passed
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

issue of spring dynamic configuration
4 participants