-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: optimize serialization/deserialization of protocol codec #6357
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The meaning of this configuration item needs to be modified on the document side
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6357 +/- ##
============================================
+ Coverage 50.41% 52.31% +1.90%
+ Complexity 5252 5217 -35
============================================
Files 941 920 -21
Lines 33279 31954 -1325
Branches 4035 3818 -217
============================================
- Hits 16776 16716 -60
+ Misses 14877 13592 -1285
- Partials 1626 1646 +20
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to make some common and safe serialization types as defaults in this pr, instead of just one seata type.
Ⅰ. Describe what this PR did
optimize serialization/deserialization of protocol codec
Ⅱ. Does this pull request fix one issue?
fixes #6267
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews