bugfix: fix known problems of docker image #6363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6363 +/- ##
============================================
+ Coverage 52.35% 52.43% +0.07%
- Complexity 5215 5245 +30
============================================
Files 920 924 +4
Lines 31942 32066 +124
Branches 3815 3833 +18
============================================
+ Hits 16724 16813 +89
- Misses 13570 13595 +25
- Partials 1648 1658 +10 |
slievrly
reviewed
Feb 22, 2024
| @@ -393,10 +393,6 @@ | |||
| </container> | |||
| <extraDirectories> | |||
| <paths> | |||
| <path> | |||
There was a problem hiding this comment.
Need to preserve the empty folder for jdbc.
slievrly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #6358
also fixed the following problems
under:openjdk:8-jre-slim
under:openjdk:11-jre-stretch
Ⅲ. Why don't you add test cases (unit test/integration test)?
Tested passed in the following version of the base image:
8
9
11
17
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews