Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: sqlserver lock_table missing status placeholder #6469

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

deung
Copy link
Contributor

@deung deung commented Apr 7, 2024

fix Error in insert operation sql of [lock_table] datasheet adapted to sqlserver database (#6468)

  1. The [lock_table] data table insert statement INSERT_LOCK_SQL_SQLSERVER adds the placeholder [?] corresponding to the [status] field.
  2. file sqlserver.sql [lock_table] create sql add [status] field.
  3. Refer to the mysql.sql improve sqlserver.sql.

@funky-eyes funky-eyes added this to the 2.1.0 milestone Apr 7, 2024
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/core core module module/server server module good first issue Good for newcomers first-time contributor first-time contributor labels Apr 7, 2024
@funky-eyes funky-eyes changed the title bugfix: fix Error in insert operation sql of [lock_table] datasheet a… bugfix: sqlserver lock_table missing status placeholder Apr 7, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please add your author information and PR information to the 2.x.md files in both the Chinese and English versions of changes under https://github.com/apache/incubator-seata/tree/2.x/changes. You can refer to the content of the registered list for filling in the details.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

changes/en-us/2.x.md Outdated Show resolved Hide resolved
changes/zh-cn/2.x.md Outdated Show resolved Hide resolved
@funky-eyes funky-eyes merged commit 6ec289d into apache:2.x Apr 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time contributor first-time contributor good first issue Good for newcomers module/core core module module/server server module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants