Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize WebSecurityConfig csrf #6749

Merged
merged 4 commits into from
Sep 2, 2024

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Aug 13, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

optimize WebSecurityConfig csrf

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

changes/zh-cn/2.x.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.19%. Comparing base (3bb8f73) to head (19f4532).
Report is 6 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x    #6749   +/-   ##
=========================================
  Coverage     52.18%   52.19%           
  Complexity     6311     6311           
=========================================
  Files          1067     1067           
  Lines         37278    37278           
  Branches       4427     4429    +2     
=========================================
+ Hits          19455    19456    +1     
+ Misses        15890    15889    -1     
  Partials       1933     1933           

see 2 files with indirect coverage changes

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 1d426ed into apache:2.x Sep 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants