optimize: optimize the initialization logic for server meta #6795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md
# Conflicts: # changes/zh-cn/2.x.md
…mingserver # Conflicts: # namingserver/src/main/java/org/apache/seata/namingserver/manager/NamingManager.java
…mingserver # Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md
…mingserver # Conflicts: # namingserver/src/main/java/org/apache/seata/namingserver/manager/NamingManager.java
…mingserver # Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md # namingserver/src/main/java/org/apache/seata/namingserver/manager/NamingManager.java # script/server/db/mysql.sql
…into optimize/optimize_namingserver
funky-eyes
changed the title
funky-eyes
reviewed
Aug 29, 2024
common/src/main/java/org/apache/seata/common/metadata/Node.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @Resource | ||
| ServerInstance serverInstance; |
There was a problem hiding this comment.
registryNamingServerProperties 和 registryProperties在server里就不需要了吧？
registryNamingServerProperties and registryProperties are not needed in the server, right?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6795 +/- ##
============================================
+ Coverage 52.30% 52.49% +0.18%
- Complexity 6373 6390 +17
============================================
Files 1078 1079 +1
Lines 37483 37462 -21
Branches 4440 4435 -5
============================================
+ Hits 19607 19665 +58
+ Misses 15940 15856 -84
- Partials 1936 1941 +5
|
funky-eyes
reviewed
Aug 30, 2024
| @@ -40,6 +43,8 @@ public class Node { | |||
|
|
|||
| private Map<String, Object> metadata = new HashMap<>(); | |||
|
|
|||
| private ObjectMapper objectMapper = new ObjectMapper(); | |||
| @@ -41,7 +41,7 @@ public class Instance { | |||
| private long timestamp; | |||
| private ClusterRole role = ClusterRole.MEMBER; | |||
| private Map<String, Object> metadata = new HashMap<>(); | |||
|
|
|||
| private final ObjectMapper objectMapper = new ObjectMapper(); | |||
…mingserver # Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
1.optimize the initialization logic for server meta
2.use jackson to serialize node
3.remove the logic of replacing node-weight using metadata
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews