-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix post method in HttpClientUtil #6835
Conversation
common/src/main/java/org/apache/seata/common/util/HttpClientUtil.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error: /home/runner/work/incubator-seata/incubator-seata/common/src/main/java/org/apache/seata/common/util/HttpClientUtil.java:94:17: '}' is not followed by whitespace. [WhitespaceAround]
Error: /home/runner/work/incubator-seata/incubator-seata/common/src/main/java/org/apache/seata/common/util/HttpClientUtil.java:94:18: 'else' is not preceded with whitespace. [WhitespaceAround]
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6835 +/- ##
============================================
+ Coverage 52.42% 52.52% +0.09%
- Complexity 6378 6388 +10
============================================
Files 1080 1080
Lines 37560 37565 +5
Branches 4452 4453 +1
============================================
+ Hits 19690 19730 +40
+ Misses 15921 15885 -36
- Partials 1949 1950 +1
|
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
#6834
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
This problem is caused by the modification in #6536