Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix post method in HttpClientUtil #6835

Merged
merged 7 commits into from
Sep 10, 2024

Conversation

LegGasai
Copy link
Contributor

@LegGasai LegGasai commented Sep 9, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

#6834

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

This problem is caused by the modification in #6536

@funky-eyes funky-eyes added first-time contributor first-time contributor module/common common module labels Sep 9, 2024
@funky-eyes funky-eyes added this to the 2.2.0 milestone Sep 9, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error: /home/runner/work/incubator-seata/incubator-seata/common/src/main/java/org/apache/seata/common/util/HttpClientUtil.java:94:17: '}' is not followed by whitespace. [WhitespaceAround]
Error: /home/runner/work/incubator-seata/incubator-seata/common/src/main/java/org/apache/seata/common/util/HttpClientUtil.java:94:18: 'else' is not preceded with whitespace. [WhitespaceAround]

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 52.52%. Comparing base (8844ce9) to head (a8797a8).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...a/org/apache/seata/common/util/HttpClientUtil.java 20.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6835      +/-   ##
============================================
+ Coverage     52.42%   52.52%   +0.09%     
- Complexity     6378     6388      +10     
============================================
  Files          1080     1080              
  Lines         37560    37565       +5     
  Branches       4452     4453       +1     
============================================
+ Hits          19690    19730      +40     
+ Misses        15921    15885      -36     
- Partials       1949     1950       +1     
Files with missing lines Coverage Δ
...a/org/apache/seata/common/util/HttpClientUtil.java 36.58% <20.00%> (-1.08%) ⬇️

... and 5 files with indirect coverage changes

@funky-eyes funky-eyes merged commit f2577cf into apache:2.x Sep 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time contributor first-time contributor module/common common module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants