Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support raft mode registry to namingserver #7114

Open
wants to merge 14 commits into
base: 2.x
Choose a base branch
from

Conversation

funky-eyes
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 17.91667% with 197 lines in your changes missing coverage. Please review.

Project coverage is 52.92%. Comparing base (4632770) to head (4ee934e).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...orage/raft/sore/RaftVGroupMappingStoreManager.java 3.33% 58 Missing ⚠️
...ta/server/instance/RaftServerInstanceStrategy.java 0.00% 32 Missing ⚠️
...uster/raft/snapshot/vgroup/VGroupSnapshotFile.java 0.00% 29 Missing ⚠️
...server/instance/AbstractSeataInstanceStrategy.java 27.27% 15 Missing and 1 partial ⚠️
...ava/org/apache/seata/common/metadata/Instance.java 7.14% 13 Missing ⚠️
...erver/cluster/raft/sync/msg/RaftVGroupSyncMsg.java 0.00% 9 Missing ⚠️
...rg/apache/seata/server/filter/RaftGroupFilter.java 10.00% 9 Missing ⚠️
...ache/seata/namingserver/manager/NamingManager.java 46.66% 5 Missing and 3 partials ⚠️
...eata/namingserver/controller/NamingController.java 0.00% 7 Missing ⚠️
.../cluster/raft/execute/vgroup/VGroupAddExecute.java 25.00% 3 Missing ⚠️
... and 6 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #7114      +/-   ##
============================================
- Coverage     53.08%   52.92%   -0.17%     
- Complexity     6795     6814      +19     
============================================
  Files          1136     1148      +12     
  Lines         40341    40562     +221     
  Branches       4723     4741      +18     
============================================
+ Hits          21416    21466      +50     
- Misses        16885    17050     +165     
- Partials       2040     2046       +6     
Files with missing lines Coverage Δ
...in/java/org/apache/seata/common/metadata/Node.java 40.00% <100.00%> (ø)
...common/metadata/namingserver/NamingServerNode.java 91.66% <ø> (-0.65%) ⬇️
...ache/seata/namingserver/entity/bo/NamespaceBO.java 59.09% <ø> (ø)
...ot/autoconfigure/loader/SeataPropertiesLoader.java 63.15% <ø> (ø)
...e/properties/server/raft/ServerRaftProperties.java 100.00% <100.00%> (ø)
...ata/server/cluster/raft/snapshot/RaftSnapshot.java 75.00% <ø> (ø)
.../src/main/java/org/apache/seata/server/Server.java 71.87% <100.00%> (ø)
...he/seata/server/cluster/raft/RaftStateMachine.java 47.34% <100.00%> (+14.30%) ⬆️
...r/cluster/raft/execute/AbstractRaftMsgExecute.java 100.00% <100.00%> (ø)
...ata/server/cluster/raft/snapshot/RaftSnapshot.java 82.75% <100.00%> (+0.61%) ⬆️
... and 23 more

... and 7 files with indirect coverage changes

@funky-eyes funky-eyes changed the title [WIP]feature: support raft mode registry to namingserver feature: support raft mode registry to namingserver Jan 16, 2025
@funky-eyes funky-eyes requested a review from ggbocoder January 16, 2025 13:34
@ggbocoder
Copy link
Contributor

please add signature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants