Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed logback.xml -> logback-spring.xml #3717

Merged
merged 4 commits into from
May 19, 2024
Merged

Conversation

soulmz
Copy link

@soulmz soulmz commented May 17, 2024

What changes were proposed in this pull request

logback.xml -> logback-spring.xml

Brief change log

  • rename logback.xml -> logback-spring.xml

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts

  • Dependencies (does it add or upgrade a dependency): no

@caicancai caicancai requested a review from wolfboys May 17, 2024 03:50
zhangmz added 2 commits May 17, 2024 16:22
modify volumeMounts streampark-default-config-volume mountPath /usr/local/service/streampark/conf > /streampark/conf
Copy link
Member

@wolfboys wolfboys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job

Copy link
Member

@wolfboys wolfboys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wolfboys wolfboys merged commit ed46fd0 into apache:dev-2.1.5 May 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants