-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update getrandom-sgx to v2.3 #350
Comments
I have forked & rebased on newest getrandom master commit: integritee-network/getrandom-sgx#1 and I'd love to create a PR to getrandom-sgx. But I can't build it yet (& tests aren't passing) due the sampleenclave encountering the following errors: error[E0557]: feature has been removed
--> /home/bhaerdi/.cargo/git/checkouts/teaclave-sgx-sdk-be25c2ad2f03718d/7c07ce0/sgx_unwind/lib.rs:24:12
|
24 | #![feature(unwind_attributes)]
| ^^^^^^^^^^^^^^^^^ feature has been removed
|
= note: use the C-unwind ABI instead
error: cannot find attribute `unwind` in this scope
--> /home/bhaerdi/.cargo/git/checkouts/teaclave-sgx-sdk-be25c2ad2f03718d/7c07ce0/sgx_unwind/libunwind.rs:65:7
|
65 | #[unwind(allowed)]
| ^^^^^^ Do you know what I'm missing here? |
This is a rust-toolchain incompatibility, i.e., this feature was most-likely stabilized meanwhile. Therefore, the feature does not need to be activated explicitly. You should run everything with the same toolchain as advised in teaclave. |
We're currently trying to update our substrate dependencies to v4.0.0-dev (see issue integritee-network/worker#346). But substrate now depends on hashbrown 0.11.0 which itself depends on getrandom 2.3 (same as in issue #326). We're currently in the development phase, so having our own getrandom fork and keeping it up to date all the time is not yet necessary from a security perspective. A simple patch to your getrandom-sgx crate would be enough.
Would it be possible to update getrandom-sgx to v2.3 so we can apply the patch?
Thanks alot for your help so far!
The text was updated successfully, but these errors were encountered: