Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Substrate update v4.0.0 dev rebase #347

Merged
merged 27 commits into from
Aug 13, 2021
Merged

Substrate update v4.0.0 dev rebase #347

merged 27 commits into from
Aug 13, 2021

Conversation

haerdib
Copy link
Contributor

@haerdib haerdib commented Aug 10, 2021 •
edited
Loading

Updates the following:

TODOs:

@haerdib haerdib marked this pull request as draft August 10, 2021 16:26
@haerdib haerdib marked this pull request as ready for review August 10, 2021 16:39
@haerdib haerdib marked this pull request as draft August 10, 2021 16:40
@haerdib haerdib marked this pull request as ready for review August 10, 2021 17:04
This was linked to issues Aug 11, 2021
Incompatibility with Hashbrown 0.11 #346
Closed
Change dependency format in Cargo.toml #329
Closed
Update outdated cargo dependencies #297
Closed
Broken Cargo Update #319
Closed
@haerdib haerdib requested a review from clangenb August 11, 2021 07:55
@haerdib haerdib removed a link to an issue Aug 11, 2021
Incompatibility with Hashbrown 0.11 #346
Closed
@haerdib haerdib requested a review from murerfel August 11, 2021 08:38
clangenb
clangenb approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.

client/Cargo.toml Show resolved Hide resolved
stf/Cargo.toml Show resolved Hide resolved
@haerdib haerdib force-pushed the substrate-update-v4.0.0-dev-rebase branch from 55eb18e to d59e1c1 Compare August 13, 2021 08:48
@haerdib haerdib mentioned this pull request Aug 13, 2021
Merged
@haerdib haerdib requested review from clangenb and brenzi August 13, 2021 12:18
clangenb
clangenb reviewed Aug 13, 2021
View reviewed changes
Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice apart from my minor comment.

Makefile Show resolved Hide resolved
@haerdib haerdib merged commit e1e86cd into master Aug 13, 2021
@haerdib haerdib deleted the substrate-update-v4.0.0-dev-rebase branch August 27, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clangenb clangenb clangenb approved these changes

@murerfel murerfel murerfel left review comments

@brenzi brenzi Awaiting requested review from brenzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change dependency format in Cargo.toml Broken Cargo Update Update outdated cargo dependencies
3 participants
@haerdib @murerfel @clangenb