upgrade SDK and rust compiler urgently needed

[brenzi]

This SDK is behind Intel's SDK for quite a while already and the supported rust compiler is very old.

We currently face a deadlock because dtolnay/proc-macro2#296 breaks our build. We can't downgrade, because other dependencies request proc-macro2-1.0.29. But we can't upgrade because teaclave's rust compiler support is outdated.

Please upgrade ASAP

[mssun]

Thanks for the report. I'll link a related PR here: #349

[mssun]

@brenzi, as discussed with @volcano0dr, he's working on a new release recently. You'll see the changes in this month.

In the meantime, I suggest to pin to a specific version (through vendoring) to avoid such problem.

[PiDelport]

@mssun, @volcano0dr: Do you have any status update about the new release? Can SDK users or contributors do anything to help?

[volcano0dr]

@PiDelport sorry for the late upgrade.
I 'v upgraded the SDK to support rust-nightly-2021-09-13, and the updated vesion is 1.1.4. The latest SDK has been pushed to v1.1.4-testing branch.
Any respondes will be greatly welcome.

[volcano0dr]

@brenzi SDK has been upgraded.

[sbellem]

A few questions & observations:

• Is the master branch considered to be fully supportive of the C++ SDK 2.14?
• Is there a reason why the rust-toolchain on master is nightly-2020-10-25 whereas on the branch https://github.com/apache/incubator-teaclave-sgx-sdk/tree/v1.1.4-testing it's nightly-2021-09-13.
• The branch https://github.com/apache/incubator-teaclave-sgx-sdk/tree/v1.1.4-testing is now at 2.15 for the C++ SDK. Are you planning to skip 2.14 in terms of releases, meaning that 1.1.4 will be for 2.15?
• Would it be possible to clarify which branch is best to use for the C++ SDK 2.14?

Thank you.

[volcano0dr]

@sbellem

• The master branch fully supports Intel sgx sdk 2.14. The rust-toolchain is nightly-2020-10-25.（The master branch can also be compiled with rust-nightly-2020-03-30）
• The v1.1.4-testing branch fully supports Intel sgx sdk 2.15. The rust-toolchain is nightly-2021-09-13.
• After testing, the v1.1.4-testing branch will be merged into the master branch.
• If you plan to use Intel sgx sdk 2.14 now, it is best to use the master branch.

[sbellem]

Thanks for the detailed answer @volcano0dr!

[haerdib]

We were able to test it and it seems to work perfectly. proc-macro was updated to v1.0.32 and rust version to nightly-2021-10-01, which successfully built & run. (integritee-network/worker#486)
Currently, not very nice patching to a teaclave fork is necessary for the mesalock libraries to work, since cargo does not allow patches to the same github repo. Other than that, nothing to complain about. Thanks a lot for your effort!

[brenzi]

when can we expect the release of 1.1.4?

[haerdib]

Update: Upgrade to rust-toolchain nightly-2021-10-30 and later is not possible, because of the following error:

error[E0522]: definition of an unknown language item: `begin_panic_fmt`
   --> /.cargo/git/checkouts/incubator-teaclave-sgx-sdk-f208006cdf70a903/19355dc/sgx_tstd/src/panicking.rs:406:1
    |
406 | #[lang = "begin_panic_fmt"]
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ definition of unknown language item `begin_panic_fmt`

[volcano0dr]

@haerdib I will upgrade rust-toolchain again recently to support rust edition 2021.

[PiDelport]

Upstream release: Intel SGX SDK 2.15.1 Release Notes (12 Nov 2021)

Changes in version 2.15.1:

• Upgraded to OpenSSL 1.1.1l.

Does v1.1.4-testing need any update for this?

Is anything else still blocking it from being merged?

[volcano0dr]

@PiDelport
v1.1.4-testing can support intel sgx sdk 2.15.1 and dcap 1.12.1
v1.1.4-testing has been merged into master

[PiDelport]

Awesome!

Does that resolve this issue?

[volcano0dr]

@haerdib I have upgraded rust-toolchain to nightly-2021-11-01.

[volcano0dr]

@PiDelport This issue has been resolved.