Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(web-server): update to Rust SGX SDK 1.1.4 #137

Merged
merged 11 commits into from
Mar 3, 2022
Merged

chore(web-server): update to Rust SGX SDK 1.1.4 #137

merged 11 commits into from
Mar 3, 2022

Conversation

PiDelport
Copy link
Collaborator

@PiDelport PiDelport commented Nov 25, 2021 •
edited
Loading

@PiDelport PiDelport self-assigned this Nov 25, 2021
@PiDelport PiDelport force-pushed the web-server/update-rust-sgx-sdk-1.1.4 branch from af80694 to f24237f Compare November 26, 2021 12:57
@PiDelport PiDelport marked this pull request as ready for review December 1, 2021 16:33
@PiDelport PiDelport force-pushed the web-server/update-rust-sgx-sdk-1.1.4 branch from c1b4759 to 366dd24 Compare January 6, 2022 13:13
@netlify
Copy link

netlify bot commented Jan 6, 2022 •
edited
Loading

✔️ Deploy Preview for nautilus-wallet canceled.

🔨 Explore the source changes: 90fec46

🔍 Inspect the deploy log: https://app.netlify.com/sites/nautilus-wallet/deploys/621cbff42a87f10007104212

@netlify
Copy link

netlify bot commented Jan 6, 2022 •
edited
Loading

✔️ Deploy Preview for affectionate-mirzakhani-7a7e75 canceled.

🔨 Explore the source changes: 90fec46

🔍 Inspect the deploy log: https://app.netlify.com/sites/affectionate-mirzakhani-7a7e75/deploys/621cbff4066f910007376807

@PiDelport PiDelport force-pushed the web-server/update-rust-sgx-sdk-1.1.4 branch from 366dd24 to 5133f45 Compare January 6, 2022 13:14
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2022 •
edited
Loading

Codecov Report

Merging #137 (90fec46) into main (6b625a2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #137   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files          80       80           
  Lines         801      801           
  Branches       85       85           
=======================================
  Hits          534      534           
  Misses        267      267

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b625a2...90fec46. Read the comment docs.

@PiDelport PiDelport requested review from jdvlio, billguo99, IscoRuta98, Titose98 and a team and removed request for billguo99, Titose98, IscoRuta98 and jdvlio January 6, 2022 15:17
@PiDelport PiDelport force-pushed the web-server/update-rust-sgx-sdk-1.1.4 branch from 6ccb227 to 29cde9b Compare January 7, 2022 18:30
@PiDelport
docs(web-server,README): update for Rust SGX SDK v1.1.4-testing branch
6abfe89
@PiDelport
build(web-server): update for Rust SGX SDK v1.1.4-testing branch
0339151 
- Intel SGX SDK: 2.14 → 2.15
- Rust toolchain: nightly-2021-05-10 → nightly-2021-09-13
@PiDelport
build(web-server): update Cargo.toml apache/incubator-teaclave-sgx-sd…
38c5063 
…k revisions
@PiDelport
build(web-server): capture codegen updates
6257ddb
@PiDelport
build(web-server): set "bench = false" to make --all-targets work
ba0b207
@PiDelport
refactor(web-server): cargo fix, clippy --fix
ee84e1d 
Warnings:

*
https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html

Clippy lints:

*
https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
*
https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
@PiDelport
refactor(web-server): cargo fix --edition-idioms: drop "extern crate"
787fc7d
@PiDelport
refactor(web-server): update Rust edition: 2018 → 2021
20a40b2
@PiDelport PiDelport force-pushed the web-server/update-rust-sgx-sdk-1.1.4 branch from 29cde9b to 1e565a6 Compare January 14, 2022 13:38
@PiDelport
Copy link
Collaborator Author

I bumped the Rust SGX SDK revision one more time, before merging.

Everything else should still be up to date, and ready to merge.

IscoRuta98
IscoRuta98 reviewed Mar 2, 2022
View reviewed changes
Copy link
Contributor

@IscoRuta98 IscoRuta98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PiDelport,
I was able to make the updates locally, and run the sgx-wallet-test with no issues (see below). No further comments at this time.

image

IscoRuta98
IscoRuta98 approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@IscoRuta98 IscoRuta98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PiDelport .
This branch is all good for merging.

billguo99
billguo99 approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@billguo99 billguo99 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building and testing web-server/sgx-wallet & web-server/sgx-wallet-test were successful. LGTM!

@PiDelport
Copy link
Collaborator Author

Awesome, thanks! 😊

@PiDelport PiDelport merged commit e001adf into main Mar 3, 2022
@PiDelport PiDelport deleted the web-server/update-rust-sgx-sdk-1.1.4 branch March 3, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IscoRuta98 IscoRuta98 IscoRuta98 approved these changes

@billguo99 billguo99 billguo99 approved these changes

@longtomjr longtomjr Awaiting requested review from longtomjr

Assignees

@PiDelport PiDelport

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PiDelport @codecov-commenter @billguo99 @IscoRuta98