[Realy][fix] Fix alpha_equal bug for attribute check #4897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @tqchen @icemelon9 @jroesch @MarisaKirisame @soiferj @mbarrett97 |
tqchen
approved these changes
Feb 17, 2020
|
Thanks @zhiics ! |
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 26, 2020
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 28, 2020
zhiics
added a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2020
zhiics
added a commit
to zhiics/tvm
that referenced
this pull request
Jun 16, 2020
zhiics
added a commit
to zhiics/tvm
that referenced
this pull request
Jun 17, 2020
zhiics
added a commit
to zhiics/tvm
that referenced
this pull request
Jun 17, 2020
tqchen
pushed a commit
that referenced
this pull request
Jun 17, 2020
* fix RemoveUnusedFunctions pass * Fix alpha_equal bug (#4897)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix a bug in alpha_equal for attribute checking where it mistakenly uses lhs as the rhs.
The discussion is here: https://discuss.tvm.ai/t/relay-analysis-alpha-equal-questions-and-potential-issues/5704/2
This is the problem 1 in the discussion. Need a separate PR for Problem2.