-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend][TFLite] Add parser support for 'square' operator #4915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyc-ruiker
reviewed
Feb 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could also refer to the implementation in convert_squared_difference
, maybe could consider using power
.
* Add parser implementation * Add relevant tests * Note: 'square' is an unary elemwise operator but it's added separately in the parser since there is no Relay 'square' op and instead we have to use 'multiply'
wyc-ruiker
approved these changes
Feb 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tqchen
approved these changes
Feb 26, 2020
Thanks @inadob @wyc-ruiker ! |
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 29, 2020
) * [Frontend][TFLite] Add parser support for square operator * Add parser implementation * Add relevant tests * Note: 'square' is an unary elemwise operator but it's added separately in the parser since there is no Relay 'square' op and instead we have to use 'multiply' * Change relay operation from 'multiply' to 'power' * Remove a redundant line as requested
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 29, 2020
) * [Frontend][TFLite] Add parser support for square operator * Add parser implementation * Add relevant tests * Note: 'square' is an unary elemwise operator but it's added separately in the parser since there is no Relay 'square' op and instead we have to use 'multiply' * Change relay operation from 'multiply' to 'power' * Remove a redundant line as requested
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2020
) * [Frontend][TFLite] Add parser support for square operator * Add parser implementation * Add relevant tests * Note: 'square' is an unary elemwise operator but it's added separately in the parser since there is no Relay 'square' op and instead we have to use 'multiply' * Change relay operation from 'multiply' to 'power' * Remove a redundant line as requested
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Apr 16, 2020
) * [Frontend][TFLite] Add parser support for square operator * Add parser implementation * Add relevant tests * Note: 'square' is an unary elemwise operator but it's added separately in the parser since there is no Relay 'square' op and instead we have to use 'multiply' * Change relay operation from 'multiply' to 'power' * Remove a redundant line as requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is built on top of #4913