Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Frontend][TFLite] Fix tests for tflite unary elemwise operations #4913

Merged
merged 1 commit into from
Feb 21, 2020
Merged

[Frontend][TFLite] Fix tests for tflite unary elemwise operations #4913

merged 1 commit into from
Feb 21, 2020

Conversation

inadob
Copy link
Contributor

@inadob inadob commented Feb 19, 2020

Previously these tests were passing just because they weren't run at all

  • 'test_op' name was not checked properly
  • the generated NumPy data wasn't passed to any function
  • all the operations don't support int32 type
  • ceil and cos come with the TFL 1.14.0.post1 schema so I added a check

Also, I added an error message for TFL operators that aren't existing in the current fbs schema.

Can you please take a look: @anijain2305 @jackwish @FrozenGene

wyc-ruiker
wyc-ruiker approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@wyc-ruiker wyc-ruiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need minor modification.

tests/python/frontend/tflite/test_forward.py Outdated Show resolved Hide resolved
@inadob inadob mentioned this pull request Feb 19, 2020
Merged
@FrozenGene
Copy link
Member

@inadob Seems our CI has some problem. Could you upload one commit and trigger the CI again? Thanks.

@inadob
Fix tests for tflite unary elemwise operations
f74029e 
* add TFLite version check for 'ceil' and 'cos'
* fix name check of test_op for positive inputs
* add error message for operator not found in the installed fbs schema
@FrozenGene
Copy link
Member

Thanks @inadob @wyc-ruiker merged.

@FrozenGene FrozenGene merged commit 0e189f0 into apache:master Feb 21, 2020
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 26, 2020
@inadob @alexwong
Fix tests for tflite unary elemwise operations (apache#4913)
a31b4f6 
* add TFLite version check for 'ceil' and 'cos'
* fix name check of test_op for positive inputs
* add error message for operator not found in the installed fbs schema
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 28, 2020
@inadob @alexwong
Fix tests for tflite unary elemwise operations (apache#4913)
e6930fa 
* add TFLite version check for 'ceil' and 'cos'
* fix name check of test_op for positive inputs
* add error message for operator not found in the installed fbs schema
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2020
@inadob @zhiics
Fix tests for tflite unary elemwise operations (apache#4913)
79216f7 
* add TFLite version check for 'ceil' and 'cos'
* fix name check of test_op for positive inputs
* add error message for operator not found in the installed fbs schema
@ZihengJiang ZihengJiang mentioned this pull request Sep 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrozenGene FrozenGene FrozenGene approved these changes

@wyc-ruiker wyc-ruiker wyc-ruiker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inadob @FrozenGene @wyc-ruiker