Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR][TIR][TARGET] Make target codegen take IRModule and PrimFunc. #5107

Merged
merged 1 commit into from
Mar 20, 2020

Conversation

tqchen
Copy link
Member

@tqchen tqchen commented Mar 19, 2020

As part of the unified IR refactor.
This PR refactors the target codegen to use IRModule containing tir::PrimFuncs.

In order to break the refactor into several steps without breaking the codebase,
we built an conversion pass to convert Array into IRModule.

The follow-up refactors will gradually move the passes covered by IRModule up
until we cover all the passes. Then we can remove the additional redundant
concepts such as LoweredFunc.

@tqchen
Copy link
Member Author

tqchen commented Mar 19, 2020

cc @icemelon9 @yzhliu @FrozenGene @vinx13 @Hzfengsy

@tqchen
Copy link
Member Author

tqchen commented Mar 20, 2020

Also cc @comaniac @zhiics perhaps it is worth considering consolidate the attr globalsymbol and externsymbol

@tqchen tqchen changed the title [TIR][TARGET] Refactor Target codegen to use IRModule and PrimFunc. [REFACTOR][TIR][TARGET] Make target codegen take IRModule and PrimFunc. Mar 20, 2020
As part of the unified IR refactor.
This PR refactors the target codegen to use IRModule containing tir::PrimFuncs.

In order to break the refactor into several steps without breaking the codebase,
we built an conversion pass to convert Array<LoweredFunc> into IRModule.

The follow-up refactors will gradually move the passes covered by IRModule up
until we cover all the passes. Then we can remove the additional redundant
concepts such as LoweredFunc.
@tqchen tqchen merged commit 841725c into apache:master Mar 20, 2020
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Apr 16, 2020
…pache#5107)

As part of the unified IR refactor.
This PR refactors the target codegen to use IRModule containing tir::PrimFuncs.

In order to break the refactor into several steps without breaking the codebase,
we built an conversion pass to convert Array<LoweredFunc> into IRModule.

The follow-up refactors will gradually move the passes covered by IRModule up
until we cover all the passes. Then we can remove the additional redundant
concepts such as LoweredFunc.
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Apr 17, 2020
…pache#5107)

As part of the unified IR refactor.
This PR refactors the target codegen to use IRModule containing tir::PrimFuncs.

In order to break the refactor into several steps without breaking the codebase,
we built an conversion pass to convert Array<LoweredFunc> into IRModule.

The follow-up refactors will gradually move the passes covered by IRModule up
until we cover all the passes. Then we can remove the additional redundant
concepts such as LoweredFunc.
@tqchen tqchen deleted the tir-codegen branch April 21, 2020 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants