[BugFix][Opencl] Explicitly cast min/max operands #9374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hope51607
requested review from
junrushao,
kparzysz-quic,
masahi,
tqchen,
vinx13 and
ZihengJiang
as code owners
shingjan
reviewed
Oct 26, 2021
|
@hope51607 Can you also add fp16 tests? I've met the "type ambiguity" error when trying to compile fp16 models for opencl before. I assume this patch fixes such issue? |
hope51607
requested review from
areusch,
comaniac,
jroesch,
merrymercy and
yzhliu
as code owners
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
* [BugFix][Opencl] Explicitly cast min/max operands * enable test_opencl_max
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* [BugFix][Opencl] Explicitly cast min/max operands * enable test_opencl_max
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered the same max / min ambiguous issue caused by the ternary operator as #2821 and #5090.
The reason is that the type of the ternary operator is not unchar.
The patch that fixes this problem seems to be missing in #5107 .
This pr simply adds them back.