Fix for issue #4831. The data_min_idx and data_max_idx were flipped. #5136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pped. Existing test cases cover this fix. In addition I have added an assert to make sure that the data_min is always less than equal to data_max.
|
@anijain2305 and @GuoliangLiCN can you take a look at the fix. |
anijain2305
approved these changes
Mar 23, 2020
|
Thanks @anijain2305 @shoubhik @GuoliangLiCN |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Apr 16, 2020
…pped. (apache#5136) Existing test cases cover this fix. In addition I have added an assert to make sure that the data_min is always less than equal to data_max.
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Apr 17, 2020
…pped. (apache#5136) Existing test cases cover this fix. In addition I have added an assert to make sure that the data_min is always less than equal to data_max.
shoubhik
added a commit
to shoubhik/incubator-tvm
that referenced
this pull request
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing test cases cover this fix. In addition I have added an assert to make sure that the data_min is always less than equal to data_max.
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.