Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMAKE] Compatible for ROCm before 3.7 #6359

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Conversation

tqchen
Copy link
Member

@tqchen tqchen commented Aug 28, 2020

This is needed to unblock CI as the CI binary docker still uses ROCm before 3.7, making it work for both.

@tqchen
Copy link
Member Author

tqchen commented Aug 28, 2020

@tqchen
Copy link
Member Author

tqchen commented Aug 28, 2020

#6345

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@electriclilies electriclilies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix :)
@mbrookhart, this is the fix for the issue that was on your PR too

@tqchen tqchen merged commit b368f9d into apache:master Aug 28, 2020
kevinthesun pushed a commit to kevinthesun/tvm that referenced this pull request Sep 17, 2020
kevinthesun pushed a commit to kevinthesun/tvm that referenced this pull request Sep 18, 2020
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants