-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tvmc] Introduce 'tune' subcommand (part 3/4) #6537
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also cc @FrozenGene @kevinthesun
Thanks @leandron , great job. Besides this, I think we could also add some features I think it is important too:
|
@FrozenGene that looks interesting. Just to clarify, is this not related to the parameter
Yes, that looks useful. Can we add it in a separate PR, considering it requires some infra to be exposed to AutoTVM? |
Yes, it is not related with
Fine to me. |
Understood. I'm happy to look into it. Can you expand a bit on how that would work, so that we can decide whether adding it here or on a future PR? |
You need to do the similar thing like we control BIG / LITTLE core via |
* introduces a subcommand to drive auto-tuning Co-authored-by: Matthew Barrett <matthew.barrett@arm.com> Co-authored-by: Luke Hutton <luke.hutton@arm.com> Co-authored-by: Giuseppe Rossini <giuseppe.rossini@arm.com>
Re-triggering CI |
This PR is passing CI again. @comaniac @FrozenGene do you mind having another look? |
Thanks @leandron @FrozenGene |
* tvmc: introduce 'tune' subcommand (part 3/4) * introduces a subcommand to drive auto-tuning Co-authored-by: Matthew Barrett <matthew.barrett@arm.com> Co-authored-by: Luke Hutton <luke.hutton@arm.com> Co-authored-by: Giuseppe Rossini <giuseppe.rossini@arm.com> * [tvmc] address code review comments * adjust --min-repeat-ms default value logic * re-arrange rpc arguments to be --rpc-tracker=hostname:port and --rpc-key=str * use a local reference of the tvmc logger * add --target-host, default to llvm Co-authored-by: Matthew Barrett <matthew.barrett@arm.com> Co-authored-by: Luke Hutton <luke.hutton@arm.com> Co-authored-by: Giuseppe Rossini <giuseppe.rossini@arm.com>
* tvmc: introduce 'tune' subcommand (part 3/4) * introduces a subcommand to drive auto-tuning Co-authored-by: Matthew Barrett <matthew.barrett@arm.com> Co-authored-by: Luke Hutton <luke.hutton@arm.com> Co-authored-by: Giuseppe Rossini <giuseppe.rossini@arm.com> * [tvmc] address code review comments * adjust --min-repeat-ms default value logic * re-arrange rpc arguments to be --rpc-tracker=hostname:port and --rpc-key=str * use a local reference of the tvmc logger * add --target-host, default to llvm Co-authored-by: Matthew Barrett <matthew.barrett@arm.com> Co-authored-by: Luke Hutton <luke.hutton@arm.com> Co-authored-by: Giuseppe Rossini <giuseppe.rossini@arm.com>
* tvmc: introduce 'tune' subcommand (part 3/4) * introduces a subcommand to drive auto-tuning Co-authored-by: Matthew Barrett <matthew.barrett@arm.com> Co-authored-by: Luke Hutton <luke.hutton@arm.com> Co-authored-by: Giuseppe Rossini <giuseppe.rossini@arm.com> * [tvmc] address code review comments * adjust --min-repeat-ms default value logic * re-arrange rpc arguments to be --rpc-tracker=hostname:port and --rpc-key=str * use a local reference of the tvmc logger * add --target-host, default to llvm Co-authored-by: Matthew Barrett <matthew.barrett@arm.com> Co-authored-by: Luke Hutton <luke.hutton@arm.com> Co-authored-by: Giuseppe Rossini <giuseppe.rossini@arm.com>
* tvmc: introduce 'tune' subcommand (part 3/4) * introduces a subcommand to drive auto-tuning Co-authored-by: Matthew Barrett <matthew.barrett@arm.com> Co-authored-by: Luke Hutton <luke.hutton@arm.com> Co-authored-by: Giuseppe Rossini <giuseppe.rossini@arm.com> * [tvmc] address code review comments * adjust --min-repeat-ms default value logic * re-arrange rpc arguments to be --rpc-tracker=hostname:port and --rpc-key=str * use a local reference of the tvmc logger * add --target-host, default to llvm Co-authored-by: Matthew Barrett <matthew.barrett@arm.com> Co-authored-by: Luke Hutton <luke.hutton@arm.com> Co-authored-by: Giuseppe Rossini <giuseppe.rossini@arm.com>
* tvmc: introduce 'tune' subcommand (part 3/4) * introduces a subcommand to drive auto-tuning Co-authored-by: Matthew Barrett <matthew.barrett@arm.com> Co-authored-by: Luke Hutton <luke.hutton@arm.com> Co-authored-by: Giuseppe Rossini <giuseppe.rossini@arm.com> * [tvmc] address code review comments * adjust --min-repeat-ms default value logic * re-arrange rpc arguments to be --rpc-tracker=hostname:port and --rpc-key=str * use a local reference of the tvmc logger * add --target-host, default to llvm Co-authored-by: Matthew Barrett <matthew.barrett@arm.com> Co-authored-by: Luke Hutton <luke.hutton@arm.com> Co-authored-by: Giuseppe Rossini <giuseppe.rossini@arm.com>
* tvmc: introduce 'tune' subcommand (part 3/4) * introduces a subcommand to drive auto-tuning Co-authored-by: Matthew Barrett <matthew.barrett@arm.com> Co-authored-by: Luke Hutton <luke.hutton@arm.com> Co-authored-by: Giuseppe Rossini <giuseppe.rossini@arm.com> * [tvmc] address code review comments * adjust --min-repeat-ms default value logic * re-arrange rpc arguments to be --rpc-tracker=hostname:port and --rpc-key=str * use a local reference of the tvmc logger * add --target-host, default to llvm Co-authored-by: Matthew Barrett <matthew.barrett@arm.com> Co-authored-by: Luke Hutton <luke.hutton@arm.com> Co-authored-by: Giuseppe Rossini <giuseppe.rossini@arm.com>
Introduce a sub-command to drive auto-tuning via command line, using AutoTVM, to produce the tuning records that can be used at compile time, or to further improve other tuning sessions. It follow good practices present on the auto-tuning tutorials.
In case you want to try it out (supposing you have your tvm built and working with this PR), you can have a look on the example below:
cc @comaniac @masahi @FrozenGene for reviews if possible