Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] v0.7 Release Planning #6421

Closed
tqchen opened this issue Sep 8, 2020 · 25 comments
Closed

[RFC] v0.7 Release Planning #6421

tqchen opened this issue Sep 8, 2020 · 25 comments

Comments

@tqchen
Copy link
Member

tqchen commented Sep 8, 2020

Thanks to everyone who works hard in the past cycle. This RFC to plan for v0.7 release. The community has always been focusing on high quality releases.

One of the major highlights in the past cycle is that we have gone through major refactors to make sure we have a fresh new foundation for new things we want to develop, and there are also exciting new features such as auto scheduler and uTVM coming in.

Considering the nature of the new foundational change, we propose to focus of this release on landing key foundational changes we have made -- for example the new TIR/target and pass infra, since they affect the API itself.

Because we are landing new features at a fast pace, we might include experimental features(that does not affect API itself) that may still need stabilization and work to cut another release after these features stabilize. We would include auto_scheduler(ansor) and intitial uTVM would be part of this release as experimental features and we will continue to polish the features in the incoming cycle.

Please share your thoughts.

In the next few days we will be populating the release note in this thread. Most release note content will be derived from our monthly report.

@tqchen tqchen mentioned this issue Sep 8, 2020
24 tasks
@tqchen
Copy link
Member Author

tqchen commented Sep 8, 2020

@ZihengJiang and @zhiics have kindly agreed to serve as release managers for this release

@junrushao
Copy link
Member

Do we have a target date for the release?

@tqchen
Copy link
Member Author

tqchen commented Sep 8, 2020

Of course the the date would depends on the status of the release, because we should always aim for quality. Based on our past experience, it might takes a few weeks.

@comaniac
Copy link
Contributor

comaniac commented Sep 8, 2020

  1. Is the error reporting feature included in this release as an experimental feature or it would be in the next release?

  2. For the experimental features, auto_scheduler and uTVM, would that be better to decorate their entry points with something like @experiment so that it pops a warning to tell users this feature is experimental (and maybe the actions we expect users to take when they encounter issues)?

@jroesch
Copy link
Member

jroesch commented Sep 8, 2020

@comaniac if we land the final error reporting PR it removes the existing error reporting from type checker completely, I think we should either choose to ship it this release or delay until next release. One worry is that there will probably be a period of stability where we iterate/polish on new errors.

@comaniac
Copy link
Contributor

comaniac commented Sep 8, 2020

@comaniac if we land the final error reporting PR it removes the existing error reporting from type checker completely, I think we should either choose to ship it this release or delay until next release. One worry is that there will probably be a period of stability where we iterate/polish on new errors.

Make sense to me (including the worry as well). Different from auto_scheduler and uTVM, error reporting is not just a standalone module that users can completely ignore, so we should be more careful.

@tqchen
Copy link
Member Author

tqchen commented Sep 8, 2020

I agree that we should mark certain features as initial support/experimental in the release note. We could also come up with documentation tags to mark the feature as experimental. I am less certain sure about shooting a warning for each function call, as they harm the overall user experience, perhaps we can start with the release note and docs?

@zhiics
Copy link
Member

zhiics commented Sep 8, 2020

Yeah, I also prefer to document it instead of throwing many warnings. In addition, we have some checker in the codebase claiming that some APIs will be deprecated in the next release. We probably want to take some actions on them as well.

@u99127
Copy link
Contributor

u99127 commented Sep 15, 2020

I'd like to see the tvmc work to be functional before we cut the release please. I'd also like to see the Ethos-N PRs land as well.

@ZihengJiang
Copy link
Contributor

@apache/tvm-committers @jroesch @u99127 @comaniac

We have a release note candidate here: #6486

Please comment it if you have anything want to be added into this release or other opinion.

@tqchen
Copy link
Member Author

tqchen commented Sep 25, 2020

Let us plan to cut a release next week. At this point we should consider "freeze the features", but please suggest a list of PRs(fixes) that need to be merged.

@comaniac
Copy link
Contributor

comaniac commented Sep 25, 2020

A brief summary of the related PRs missed in the current release note candidates. Not sure if all of them have to be listed so just for reference. Except for the note followed by the PR indicating its status, all PRs listed here are merged.

Automatic Scheduling (Experimental)

BYOC

TVMC(Experimental)

@tqchen
Copy link
Member Author

tqchen commented Sep 25, 2020

At this point, we should focus on stablization, so we don't have to rush in features like Vitis-AI and TensorRT and can do them in the v0.8 cycle(for better stablization). We should instead list PRs that contains necessary fixes that need to be inlcuded.

@comaniac
Copy link
Contributor

At this point, we should focus on stablization, so we don't have to rush in features like Vitis-AI and TensorRT and can do them in the v0.8 cycle(for better stablization). We should instead list PRs that contains necessary fixes that need to be inlcuded.

Make sense. Removed them from the list.

@ZihengJiang
Copy link
Contributor

@comaniac Thanks for checking! I have added missing ones except those are not merged yet.

@leandron
Copy link
Contributor

leandron commented Sep 25, 2020

TVMC(Experimental)
* [tvmc] Introduce 'tune' subcommand (part 3/4) (#6537) -- expected to merge in 1 week.
* TVMC part 4/4: Tutorial -- not filed yet but I suppose it's required if we list TVMC as an experimental feature in 0.7 (cc @leandron, @u99127).

@comaniac, yes, it would be great to merge #6537 before the release, lets try to solve all the issues early next week; Also, "part 4/4", related to tvmc run is coming very soon, Monday max, and it would be great to have it as well, so that we have the first package complete

@tqchen
Copy link
Member Author

tqchen commented Sep 28, 2020

Let us aim for Oct 1st as the tentative date for the release cutting. would be great to merge #6537 before then

@leandron
Copy link
Contributor

Let us aim for Oct 1st as the tentative date for the release cutting. would be great to merge #6537 before then

So, #6537 and #6578 would be the final two PRs to complete the first version of tvmc.

@comaniac
Copy link
Contributor

So, #6537 and #6578 would be the final two PRs to complete the first version of tvmc.

Per offline discussion with @leandron, the final PR for TVMC would be a simple tutorial planned to be sent by tomorrow. We will do our best to review and merge them before Oct 1st.

@leandron
Copy link
Contributor

So, #6537 and #6578 would be the final two PRs to complete the first version of tvmc.

Per offline discussion with @leandron, the final PR for TVMC would be a simple tutorial planned to be sent by tomorrow. We will do our best to review and merge them before Oct 1st.

The mentioned tutorial PR is #6597

@ZihengJiang
Copy link
Contributor

@leandron @comaniac @tqchen
We are still waiting CI for #6597 and #6578 . I have added them into the release note and let's merge them tomorrow morning.

@comaniac
Copy link
Contributor

comaniac commented Oct 2, 2020

@leandron @comaniac @tqchen
We are still waiting CI for #6597 and #6578 . I have added them into the release note and let's merge them tomorrow morning.

Thanks. I am actually waiting to merge them today but still waiting for their CIs.

@comaniac
Copy link
Contributor

comaniac commented Oct 2, 2020

@ZihengJiang both were merged.

@zhiics
Copy link
Member

zhiics commented Oct 2, 2020

@comaniac cool, thanks. We plan to make a cut tomorrow.

@tqchen
Copy link
Member Author

tqchen commented Oct 2, 2020

https://github.com/apache/incubator-tvm/tree/v0.7

@tqchen tqchen closed this as completed Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants