Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BYOC][ACL] Add maximum support for float32 #6506

Merged
merged 2 commits into from
Sep 23, 2020
Merged

[BYOC][ACL] Add maximum support for float32 #6506

merged 2 commits into from
Sep 23, 2020

Conversation

giuseros
Copy link
Contributor

  • Added the code generation flow in arm_compute_lib.py
  • Added the runtime calls in acl_runtime.cc

Change-Id: I69c5522f05a46c1dd235da5d57fe499134de0425

ACL integration: add maximum support for float32.
d0d39b0 
* Added the code generation flow in arm_compute_lib.py
* Added the runtime calls in acl_runtime.cc

Change-Id: I69c5522f05a46c1dd235da5d57fe499134de0425
@giuseros
Copy link
Contributor Author

@lhutton1 Do you mind reviewing it?

lhutton1
lhutton1 reviewed Sep 17, 2020
View reviewed changes
Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good overall. Could you also add the operator to the table in docs/deploy/arm_compute_lib.rst as well :)

tests/python/contrib/test_arm_compute_lib/test_maximum.py Show resolved Hide resolved
comaniac
comaniac reviewed Sep 17, 2020
View reviewed changes
Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Please address comments from @lhutton1

@zhiics
Copy link
Member

zhiics commented Sep 18, 2020

@comaniac please manage to test your committer permission:)

@comaniac comaniac changed the title ACL integration: add maximum support for float32. [BYOC][ACL] Add maximum support for float32 Sep 18, 2020
@comaniac comaniac added the status: need update need update based on feedbacks label Sep 21, 2020
@comaniac
Copy link
Contributor

@giuseros please address the comments from @lhutton1 and we can merge this PR.

@giuseros
Copy link
Contributor Author

Hi @comaniac , @lhutton1 ,
I will have them addressed by tomorrow.

Thanks,
Giuseppe

comaniac
comaniac approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@comaniac comaniac left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just wait for the last commit of adding the operator to the doc.

Add maximum to the list of supported functions
3e067d9 
Change-Id: Ia49087756be4c3ac92a3dc76fe03fb00de468f8d
lhutton1
lhutton1 approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo the doc fix

@comaniac comaniac merged commit b6e6395 into apache:master Sep 23, 2020
@comaniac
Copy link
Contributor

Thanks @giuseros @lhutton1 @zhiics

@comaniac comaniac added status: accepted and removed status: need update need update based on feedbacks labels Sep 23, 2020
@comaniac comaniac mentioned this pull request Sep 25, 2020
Closed
@ZihengJiang ZihengJiang mentioned this pull request Sep 25, 2020
Closed
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Oct 13, 2020
[BYOC][ACL] Add maximum support for float32 (apache#6506)
d182f87 
* ACL integration: add maximum support for float32.

* Added the code generation flow in arm_compute_lib.py
* Added the runtime calls in acl_runtime.cc

Change-Id: I69c5522f05a46c1dd235da5d57fe499134de0425

* Add maximum to the list of supported functions

Change-Id: Ia49087756be4c3ac92a3dc76fe03fb00de468f8d
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Oct 14, 2020
[BYOC][ACL] Add maximum support for float32 (apache#6506)
f382d8d 
* ACL integration: add maximum support for float32.

* Added the code generation flow in arm_compute_lib.py
* Added the runtime calls in acl_runtime.cc

Change-Id: I69c5522f05a46c1dd235da5d57fe499134de0425

* Add maximum to the list of supported functions

Change-Id: Ia49087756be4c3ac92a3dc76fe03fb00de468f8d
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Oct 15, 2020
[BYOC][ACL] Add maximum support for float32 (apache#6506)
055e664 
* ACL integration: add maximum support for float32.

* Added the code generation flow in arm_compute_lib.py
* Added the runtime calls in acl_runtime.cc

Change-Id: I69c5522f05a46c1dd235da5d57fe499134de0425

* Add maximum to the list of supported functions

Change-Id: Ia49087756be4c3ac92a3dc76fe03fb00de468f8d
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Oct 15, 2020
[BYOC][ACL] Add maximum support for float32 (apache#6506)
38f07e3 
* ACL integration: add maximum support for float32.

* Added the code generation flow in arm_compute_lib.py
* Added the runtime calls in acl_runtime.cc

Change-Id: I69c5522f05a46c1dd235da5d57fe499134de0425

* Add maximum to the list of supported functions

Change-Id: Ia49087756be4c3ac92a3dc76fe03fb00de468f8d
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Oct 16, 2020
[BYOC][ACL] Add maximum support for float32 (apache#6506)
ddafcc8 
* ACL integration: add maximum support for float32.

* Added the code generation flow in arm_compute_lib.py
* Added the runtime calls in acl_runtime.cc

Change-Id: I69c5522f05a46c1dd235da5d57fe499134de0425

* Add maximum to the list of supported functions

Change-Id: Ia49087756be4c3ac92a3dc76fe03fb00de468f8d
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Oct 19, 2020
@trevor-m
[BYOC][ACL] Add maximum support for float32 (apache#6506)
f6931f6 
* ACL integration: add maximum support for float32.

* Added the code generation flow in arm_compute_lib.py
* Added the runtime calls in acl_runtime.cc

Change-Id: I69c5522f05a46c1dd235da5d57fe499134de0425

* Add maximum to the list of supported functions

Change-Id: Ia49087756be4c3ac92a3dc76fe03fb00de468f8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comaniac comaniac comaniac approved these changes

@lhutton1 lhutton1 lhutton1 approved these changes

Assignees

@comaniac comaniac

Labels
status: accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@giuseros @zhiics @comaniac @lhutton1